My tests of account_fixed_asset, bugs, suggestions and diagram

Here the dia file for the diagram.

Hello ,

Our R&D Teams are focused on the latest OpenERP version, and this issue does not affect it.

Thanks

On 04. 05. 11 12:27, YannickB wrote:
> Public bug reported:
>
> Hi everyone,
>
> This bug is about the branch https://code.launchpad.net/~ovnicraft
> /openobject-addons/asset_refactor_wizards, especially the module
> account_fixed_asset.
>
> I am very interested by this module and so I'd like to improve it. First
> I found some bads bugs with the wizard :
>
> Impossible to create direct asset (Invoice field required and read-only)
> Impossible to use wizard "Initial Value" (Impairment account refer to account.acount and not account.account)
> Impossible to use wizard "Abandon" and "Suppress"(Field 'asset_id' does not exist in object 'browse_record(account.asset.method, 10)')
> Impossible to use "Change parameters" (global name 'ids' is not defined)
> Impossible to use "Reevalute Asset" ('account_asset_method' object has no attribute '_check_date')
>
> I manage to create asset with the invoice, and create periodical account
> entry, even if I'm not sure the calculation was right.
>
> If we have the possibility to create direct asset, I suggest to improve the input of the data by :
> In the asset, you should refresh Depr.Duration, Frequency of writing and progressive factor when Depreciation Method change, at least if these fields aren't already filled.
> Also, you should refresh Depreciation Method and the account information when the Asset Category change, at least if these fields aren't already filled.
>
> Finally, I made a diagram about this module, joined to this bug report. I think this is really necessary because asset management is very complicated and technicals specifications should be very useful for the teamwork.
> Please help me to fill the diagram, so next I could ask my devmen to help debug the module but I could only do it if I know exactly the way you want to implement the functionality.
>
> Thanks for reading and good jobs, this is a huge and needed improvement
> of the asset management in OpenERP.
>
> ** Affects: openobject-addons
> Importance: Undecided
> Status: New
>
Yannick,

thank you for your input! I will have a look in detail, it seems you
provided some nice ideas! This is a module under development, either on
my branch or on ovnicraft's one. please be patient, and do not hesitate
to contribute.
there is also a wiki, a discussion on the accounting experts list, and
more :-)

have a look https://launchpad.net/~bstanciu

lp:~bstanciu/openobject-addons/account-fixed-assets (no improvements yet
compared to ovnicraft's one, but some will come soon)

I didn't really provide any ideas, just describe the ovnicraft's work. But in fact yeah, description, technical specification, this is what OpenERP lacks right now.

Without it, you can't fully understand the current work, you can't precisely describe the improvement that should be done, and yeah I want to change it. Here I provided some minor tests, and a first description diagram of the module, hopping some others peoples will better understand the work and help.

Even this diagram is not complete yet, but at least this is a beginning.

On 07. 05. 11 19:54, YannickB wrote:
> I didn't really provide any ideas, just describe the ovnicraft's work.
i still think that your suggestions are valuable input :-)

however,what you touched is NOT ovnicraft's work, but original authors'
and mine (see my wiki for authors' names). I do not want to minimise
ovnicraft's efforts, but for the time being he focused on the rest of
wizards, to upgrade them to the new way (see openerp doc for differences)
> But in fact yeah, description, technical specification, this is what
> OpenERP lacks right now.
i fully agree, but i understand that this is an additional burden with
no direct benefits (well, we can talk about that, but no one will PAY
for doc)
> Without it, you can't fully understand the current work, you can't
> precisely describe the improvement that should be done, and yeah I want
> to change it. Here I provided some minor tests, and a first description
> diagram of the module, hopping some others peoples will better
> understand the work and help.
i will include the dia in the wiki (if possible) and of course, it will
need some updates... thank you for that!
> Even this diagram is not complete yet, but at least this is a beginning.
>
i will make some other points in your original mail..

thank you
regards,
b

On 04. 05. 11 12:27, YannickB wrote:
> Public bug reported:
>
> Hi everyone,
>
> This bug is about the branch https://code.launchpad.net/~ovnicraft
> /openobject-addons/asset_refactor_wizards, especially the module
> account_fixed_asset.
>
> I am very interested by this module and so I'd like to improve it.
thank you!
> First
> I found some bads bugs with the wizard :
>
> Impossible to create direct asset (Invoice field required and read-only)
it was already flagged, I was aware of it. the invoice filed is just the
top of the iceberd, I will need to have a deeper look, as I remember
more issues were involved.
> Impossible to use wizard "Initial Value" (Impairment account refer to account.acount and not account.account)
> Impossible to use wizard "Abandon" and "Suppress"(Field 'asset_id' does not exist in object 'browse_record(account.asset.method, 10)')
> Impossible to use "Change parameters" (global name 'ids' is not defined)
> Impossible to use "Reevalute Asset" ('account_asset_method' object has no attribute '_check_date')
>
hopefully, based on ovnicraft's announcement, they will work soon
> I manage to create asset with the invoice, and create periodical account
> entry, even if I'm not sure the calculation was right.
thiswas the minimum I plammed for the first round, and I do believe that
calculations are correct. please just be aware that the progressive
depreciation method is mixed, once the value is lower that the
theoretical linear, it switches to linear. I think that this shoud be
split, into progressive and mixt (and linear, of course)
> If we have the possibility to create direct asset, I suggest to improve the input of the data by :
> In the asset, you should refresh Depr.Duration, Frequency of writing and progressive factor when Depreciation Method change, at least if these fields aren't already filled.
> Also, you should refresh Depreciation Method and the account information when the Asset Category change, at least if these fields aren't already filled.
>
this is how it works for the newly acquired asset (via invoice) so I see
no reason why it will be different for "direct" creation as you called it.
> Finally, I made a diagram about this module, joined to this bug report. I think this is really necessary because asset management is very complicated and technicals specifications should be very useful for the teamwork.
thank you! I agree that it can help a lot!
> Please help me to fill the diagram, so next I could ask my devmen to help debug the module but I could only do it if I know exactly the way you want to implement the functionality.
I will try, I will put it on the accounting experts discussion and in
the wiki. i am rather new to the dia program, so I might need help :-)
> Thanks for reading and good jobs, this is a huge and needed improvement
> of the asset management in OpenERP.
>
> ** Affects: openobject-addons
> Importance: Undecided
> Status: New
>
regards,
bogdan

hi there,

I commited the fix for the invoice_id bug, it is not required anymore.
here: lp:~bstanciu/openobject-addons/account-fixed-assets

thank you!

Thank you for your answers,

>however,what you touched is NOT ovnicraft's work, but original authors'
and mine (see my wiki for authors' names). I do not want to minimise
ovnicraft's efforts, but for the time being he focused on the rest of
wizards, to upgrade them to the new way (see openerp doc for differences)

Sorry for it, please have my congratulations for the work.

>i fully agree, but i understand that this is an additional burden with
no direct benefits (well, we can talk about that, but no one will PAY
for doc)

Yes, this is why I don't like everyone (including me) in the openerp community are professional who make their life with. We really need communication campaign for uninterested contributor, like students, users, experts etc... I am currently focus on it in France.

>thiswas the minimum I plammed for the first round, and I do believe that
calculations are correct. please just be aware that the progressive
depreciation method is mixed, once the value is lower that the
theoretical linear, it switches to linear. I think that this shoud be
split, into progressive and mixt (and linear, of course)

Unfortunately, I just can't understand because my expertise in asset is not enough. My point is that it's impossible to guess how the calculations is done and help to improve it just by testing the module. You should write the formula somewhere, in the description or in the dia file.

>this is how it works for the newly acquired asset (via invoice) so I see
no reason why it will be different for "direct" creation as you called it.

With the invoice, all the asset are completely automatically filled, I will give you an example, in sale order line when you give the product it will automatically filled the other field like UoM, unit price, description, taxes etc... Here it is the same, when in direct input, when you give the asset categorie or depreciation method it should fill the others fields. This is an important ergonomic rule for the input. I suppose it can easily be done with an on_change or something else.

>I will try, I will put it on the accounting experts discussion and in
the wiki. i am rather new to the dia program, so I might need help :-)

Don't hesitate, this is purely BPMN but I made some adaptations to use with OpenERP ;).
Once again, thanks for your reply.

On 09. 05. 11 11:15, YannickB wrote:
> Thank you for your answers,
>
>> however,what you touched is NOT ovnicraft's work, but original authors'
> and mine (see my wiki for authors' names). I do not want to minimise
> ovnicraft's efforts, but for the time being he focused on the rest of
> wizards, to upgrade them to the new way (see openerp doc for differences)
>
> Sorry for it, please have my congratulations for the work.

nothing to be sorry of, just to know to whom to complain :-) i am sure
that ovnicraft will (already did actually) improve many things!
>> i fully agree, but i understand that this is an additional burden with
> no direct benefits (well, we can talk about that, but no one will PAY
> for doc)
>
> Yes, this is why I don't like everyone (including me) in the openerp
> community are professional who make their life with. We really need
> communication campaign for uninterested contributor, like students,
> users, experts etc... I am currently focus on it in France.
>
sounds good! anyway, i wasted so much time in trying to find info which
should be found in the doc, that i would dare to say that making the doc
actually pays :-)
>> thiswas the minimum I plammed for the first round, and I do believe that
> calculations are correct. please just be aware that the progressive
> depreciation method is mixed, once the value is lower that the
> theoretical linear, it switches to linear. I think that this shoud be
> split, into progressive and mixt (and linear, of course)
>
> Unfortunately, I just can't understand because my expertise in asset is
> not enough. My point is that it's impossible to guess how the
> calculations is done and help to improve it just by testing the module.
> You should write the formula somewhere, in the description or in the dia
> file.
>
did you check the wiki? i think they are there.
http://openobject.com/wiki/index.php/Fixed_Assets_Management_Module

>> this is how it works for the newly acquired asset (via invoice) so I see
> no reason why it will be different for "direct" creation as you called it.
>
> With the invoice, all the asset are completely automatically filled, I
> will give you an example, in sale order line when you give the product
> it will automatically filled the other field like UoM, unit price,
> description, taxes etc... Here it is the same, when in direct input,
> when you give the asset categorie or depreciation method it should fill
> the others fields. This is an important ergonomic rule for the input. I
> suppose it can easily be done with an on_change or something else.

oh, i guess i misunderstood. i fully agree, and it is on my list!
selecting a category shall fill most of the fields (cat has a default
method)
>> I will try, I will put it on the accounting experts discussion and in
> the wiki. i am rather new to the dia program, so I might need help :-)
i put it already in the wiki. we should try to complete it now :-)
> Don't hesitate, this is purely BPMN but I made some adaptations to use with OpenERP ;).
> Once again, thanks for your reply.

btw when opening the file i get a file missing message: The image file
'image-schéma-dia-boucle.png' was not found.

>did you check the wiki? i think they are there.
http://openobject.com/wiki/index.php/Fixed_Assets_Management_Module

How just I could miss it... I'll check it thanks ;)

>btw when opening the file i get a file missing message: The image file
'image-schéma-dia-boucle.png' was not found.

Yeah I needed to use an image for representing the subprocess, dia isn't really good for it (yet the best software for representing BPMN process, with enough flexibility to adapt for OpenERP usage).

Please find attach the image-schéma-dia-boucle.png, put it in the same folder than the dia file.