OpenShot Video Editor

Larger frame skipping when seeking with SHIFT+Arrow keys

Bug #1010273 reported by Patrick Boivin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Medium
Unassigned
OpenShot Video Editor 1.4.3

Bug Description

Left and Right arrows skip 1 frame backward or forward. The idea is to make it skip more frames when holding the Shift key, to "seek faster". I have attached a patch that demonstrates the idea. Tested against revno 678.

Thanks!

Tags: feature

Related branches

lp://qastaging/openshot/1.4
Revision history for this message
Patrick Boivin (pboivin) wrote :
Olivier Girard (eolinwen)
Changed in openshot:
importance: Undecided → Medium
milestone: none → 1.4.3
Revision history for this message
Andy Finch (fincha) wrote :

I notice in the patch you have set it to 60 frames - how did you arrive at that value? Do you think it would make more sense to use the fps, or a multiple thereof, so instead of seeking by 1 frame it seeks by 1 second or something?

Changed in openshot:
milestone: 1.4.3 → none
importance: Medium → Wishlist
Revision history for this message
Patrick Boivin (pboivin) wrote :

I am not a very experienced developer so there's an excellent opportunity to learn from my mistakes ;)

Yes, I must say that 60 was not very well thought out. Most of what I shoot is at 30 fps... I am not sure of why I thought that, for the purpose of demonstrating the idea, a "2 second" step length felt alright. I totally agree that it is better to have that sort of feature be aware of FPS.

Here's an updated patch that incorporates your suggestions.

Revision history for this message
Andy Finch (fincha) wrote :

Thanks for the idea & the patch, I have committed it to the trunk, with a small modification.

Changed in openshot:
status: New → Fix Committed
milestone: none → 1.4.3
Jonathan Thomas (jonoomph)
summary: - Feature request: larger frame skipping when seeking with Shift+Arrows
+ Larger frame skipping when seeking with SHIFT+Arrow keys
Changed in openshot:
importance: Wishlist → Medium
Jonathan Thomas (jonoomph)
Changed in openshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.