Video preview button - pause button visualisation missing

This is related to:
https://answers.launchpad.net/openshot/+question/79753

There were some complications about updating the Play/Pause icon with the SDL video window. It would create holes in the video... seemed like a low-priority problem. So, that's why the button isn't being updated yet. However, this is an issue, so I'll confirm this bug.

The state (running or pausing) is reflected in the caption of the preview window. But this is not very clear, so my preference would be also to change the icon, according to the state.

I would have to agree as a new user I found the icon not changing very odd.

The original bug do not appears on ubuntu 10.10 for me, so maybe it's time to solve this bug ?

I had tried to fix it sometime ago and if I don't remember very well, but the problem was with the refresh (or redraw? or whatever) that was necessary after changing the icon in the toolbutton. This is not necessary when using stocks.

For me it is working fine too (Ubuntu 10.10, OpenShot 1.3.0~alpha1):

 def on_tlbPlay_clicked(self, widget, *args):
  print "on_tlbPlay_clicked called with self.%s" % widget.get_name()

  # get correct gettext method
  _ = self._

  # Get the current speed
  current_speed = self.MyVideo.get_speed()

  # Refresh the MLT XML file
  self.project.RefreshXML()

  # is video stopped?
  if current_speed == 0:

   # start video
   self.MyVideo.play()

   # update video preview tab
   #self.lblVideoPreview.set_text(_("Video Preview"))

   # update stock and tooltip text
   self.tlbPlay.set_stock_id("gtk-media-pause")
   self.tlbPlay.set_tooltip_text(_("Pause"))

  else:

   # stop video
   self.MyVideo.pause()

   # update video preview tab
   #self.lblVideoPreview.set_text(_("Video Preview (Paused)"))

   # update stock and tooltip text
   self.tlbPlay.set_stock_id("gtk-media-play")
   self.tlbPlay.set_tooltip_text(_("Play"))

HI,
Thanks a lot and after checking, it will be in the next version.

Hi Cenwen,
Actually I was very naïve and did ahuge mistake. This solution that I provided solves only for the click of the Play button. Clicking other buttons or the timeline, for example, result in a wrong icon a tip being shown.

This should be done in the occasion of MyVideo.pause or .play and MyVideo.setspeed being called, so I'll have to look at it in more detail. Sorry for that!

Don't worry for that. Anyway, it will be tested before to be in a version. Thanks to give more explanations, it will avoided to find why it will not worked. And, now, i am not really sure that could be put in the next version.
So, you will have more time to see that.

Hi again,
There are some more "bugs" related to Play/Pause button than the simple switch of the button icon and tip. Other buttons (and timeline/head and preview scroll bar) in the Main window that affect the "status" of the Play/Pause button have problems, related or not with the Play/Pause button. I'm slowly testing and writing down which are the observed behaviors from an user point of view (without going through the source code) and writing down which is the expected behavior in each case. When I'm ready I'll bring it here and see if the expected behaviors are correct and if I didn't miss anything, before start coding. Similar problems probably also affect the buttons in the preview of the properties window.

I still only see the Play button, so I don't think this bug is actually fixed yet?

Effectively. And like we are nearly of a solution, I put it in the next milestone.

Sometimes scrolling in the video leads to temporary "hangs" of openshot, so a visual indication if openshot is still playing or paused for some reason would be very helpful.

This happens to me with FullHD AVCHD files on OpenShot 1.4.0, Ubuntu 11.04.

Running OpenShot 1.4.0 on Ubuntu 11.10 and this problem is still present.

This is a usability bug as it doesn't provide users with sufficient feedback about what a button will do and what is happening and makes things very tricky for new users.

Hi Thomas,
May I suggest a quick fix as per v1.4.3alpha1?

in video.py: add:
line 23:
=import gobject
=from classes import profiles
+from gtk import STOCK_MEDIA_PAUSE
+from gtk import STOCK_MEDIA_PLAY

in pause(), line 337:
= # pause the video
+ self.main_form.tlbPlay.set_tooltip_text(self.main_form._('Play'))
+ self.main_form.tlbPlay.set_stock_id(STOCK_MEDIA_PLAY)
= self.isPlaying = False

in play(), line 351:
= # play the video
+ self.main_form.tlbPlay.set_stock_id(STOCK_MEDIA_PAUSE)
+ self.main_form.tlbPlay.set_tooltip_text(self.main_form._('Pause'))
= self.isPlaying = True
= self.p.set_speed(1)

Regards,

Emmanuel

Compared to proposal from Rodrigo Castelan Carlson (rodrigocarlson) wrote on 2011-01-20, this patch sems to work in all playing scenario. We might considere adding 'pause' translations.

Thanks a lot for this patch.
Anyway, even without this patch we are at the end of this bug. Because the Pause button will be available in the 2.0.0 thanks to our library.
I move it in the next milestone.

this patch has been comited here https://code.launchpad.net/~battmanu/+junk/openshot

The only problem with the supplied patch (as applied in the branch from battmanux) is that it only works if you have the Openshot Preference 'Use Stock Icons' set to Yes. If it is set to No then the Pause visualisation button does not show.

I pushed an update in my branch to fix the behavior when theme are used. However, pause_big.png icon need to be improved to match each style. Is there SVG source files for themes png icon files?

@battmanux

No, png icon is present on each theme but not the SVG file. But the
big_pause icon is present too.
Thx.

2012/8/22 battmanux <email address hidden>

> I pushed an update in my branch to fix the behavior when theme are used.
> However, pause_big.png icon need to be improved to match each style. Is
> there SVG source files for themes png icon files?
>
> --
> You received this bug notification because you are a member of OpenShot
> Bugs, which is subscribed to OpenShot Video Editor.
> https://bugs.launchpad.net/bugs/440802
>
> Title:
> Video preview button - pause button visualisation missing
>
> Status in OpenShot Video Editor:
> Confirmed
>
> Bug description:
> 1) OS Name & Version:
> Ubuntu 9.04
> 2) Version of the OpenShot Build Wizard
> ? updated from official PPA on 2.10.2009
> 3) Version of OpenShot (displayed in the terminal when you run OpenShot)
> 0.9.42
>
> Problem description:
> - problem is in "Video Preview" panel - play button is affected - all
> the time tooltip (displayed on mouse over) is "Play" never "Pause", even if
> video is being played in Video Preview panel, the same is true for icon
> used for play button - never is pause button displayed, only play
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openshot/+bug/440802/+subscriptions
>
> --
> Mailing list: https://launchpad.net/~openshot.bugs
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openshot.bugs
> More help : https://help.launchpad.net/ListHelp
>

--
Olivier
Cenwen un elfe sur la banquise/ an elve on the ice
Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot :
http://linuxevolution.wordpress.com/
Le forum d'Openshot où vous me trouverez : http://openshotusers.com/
http://openshotusers.com/forum/index.php
Nothing is lost until the last second.
The family motto : When we want, we can.
Astuces, Actualités, Logiciels, bref sur tout ce que je ne fais d'articles
dessus Google+ <https://plus.google.com/u/0/111472725110173916234/posts>

Thanks for looking at this, I have committed this to the trunk.