VMwareAPI-Team

NVP plugin raises OutOfSync when listing shared networks

Bug #1130171 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VMwareAPI-Team
New
High
Unassigned
neutron
Fix Released
High
Salvatore Orlando
neutron 2013.1 "grizzly"

Bug Description

Currently quantum NVP plugin always raises when listing networks if shared networks are present.

As found out by Aaron:
I just checked this out and this is a bug. When we query NVP for the networks it knows about we pass in a filter so that nvp only returns us the networks with a tag that are owned by the tenant id. Since this network is not owned by the tenant the code we have believes that the two are out of sync.

Unfortunately we cannot say os_tid=tenant_id or shared in nvp queries, so we'll have to do two nvp queries.
We will add a new tag for marking shared networks.

Tags: nicira
Revision history for this message
dan wendlandt (danwent) wrote :

i thought I saw arosen with a patch for this already... would be good to check with him, as this may be a dup. Or I may be imagining things :)

Revision history for this message
Aaron Rosen (arosen) wrote :

My bug fix fixes this error from being raised but there is still a bug here. What actually ends up happening is when a user does quantum net-list in the plugin we query NVP for all the lswitches that it knows about with a tag value==tenant_id; Since the tenant does not own the shared network we are not actually getting the status of this network. The way it currently stands is that shared networks will be returned in error state I believe.

Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Totally agree with your analysis.
I am already aware of the problem here - and discussed it offline with Dan.

As you know I already have a patch for this. I just need to tweak it a bit following your patch, and then I'll push it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/22980

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/22980
Committed: http://github.com/openstack/quantum/commit/8fbf5441cdc9c119b6bbe7c0cd49391886ba405e
Submitter: Jenkins
Branch: master

commit 8fbf5441cdc9c119b6bbe7c0cd49391886ba405e
Author: Salvatore Orlando <email address hidden>
Date: Tue Jan 22 08:30:02 2013 -0800

    Fix retrieval of shared networks

    Bug 1130171

    This patch adds a new tag_scope, 'shared', in order to allow
    the NVP plugin to retrieve also shared networks from NVP when
    listing networks. This way it won't appear as Quantum has a
    network without a corresponding lswitch in NVP

    Change-Id: I24f950d54c0b9e582c92e8008e75ebd00f6c9fe3

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-rc1 → 2013.1
Tracy Jones (tjones-i)
Changed in openstack-vmwareapi-team:
importance: Undecided → High
Revision history for this message
Salvatore Orlando (salvatore-orlando) wrote :

Hi Tracy! Is there a regression for this bug?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.