nvmeof connector: get ready for nvme-cli 2.0

Bug #1961222 reported by Brian Rosmaita
This bug affects 1 person
Affects Status Importance Assigned to Milestone
In Progress
Gorka Eguileor

Bug Description

The nvmeof connector makes calls out to nvme-cli, for example, in create_hostnqn() in os_brick/privileged/nvmeof.py, where our code currently expects that the error_code will map to some errno.

A commit into nvme-cli that changes the exit code to always be either 0 or 1 [0] is in v2.0-rc2, so we can no longer rely on the error_code. Instead, we'll probably have to parse the error message (which, by the way, is sent to stdout; the output sent to stderr is useless).

[0] https://github.com/linux-nvme/nvme-cli/pull/1345/commits/13f74d20e1d9e571368b1d06fe9889a2fdd29849

Changed in os-brick:
status: New → Triaged
importance: Undecided → High
importance: High → Medium
Revision history for this message
Gorka Eguileor (gorka) wrote :
Changed in os-brick:
assignee: nobody → Gorka Eguileor (gorka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-brick (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/os-brick/+/895195

Changed in os-brick:
status: Triaged → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.