os-brick

Can't attach NVMe volumes

Series xena
Bug #1945323

Bug #1945323 reported by Ivan Kolodyazhny on 2021-09-28

This bug affects 3 people

	Status	Importance	Assigned to	Milestone
os-brick	Fix Released	Critical	Vladislav Belogrudov	os-brick 5.0.1 "xena-critical"
Xena	Fix Committed	Critical	Vladislav Belogrudov	os-brick 5.0.1 "xena-critical"
Yoga	Fix Released	Critical	Unassigned

Bug Description

With the latest os-brick release NVMe volume attach is broken on nova master branch

Tags:

OpenStack Infra (hudson-openstack) on 2021-09-28

Changed in nova:
status:	New → In Progress

Revision history for this message

Abdallah Yasin (abdysn) wrote on 2021-09-28:

deploying nvme with [1] and trying to attach volumes to vms causes [2]
patch [3] fixes the issue

[1] https://paste.openstack.org/show/809648/
[2] https://paste.openstack.org/show/809647/
[3] https://review.opendev.org/c/openstack/nova/+/811413

Revision history for this message

Lee Yarwood (lyarwood) wrote on 2021-09-28:

Adding os-brick as I'm not entirely convinced this isn't an issue with the https://review.opendev.org/c/openstack/os-brick/+/800014 fix itself.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-09-28: Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/811447

Sofia Enriquez (lsofia-enriquez) on 2021-09-29

tags:	added: attach nvme volume
Changed in os-brick:
importance:	Undecided → Medium
status:	New → Fix Committed

Revision history for this message

Lee Yarwood (lyarwood) wrote on 2021-09-30:

Did you mean to move this to Fix Committed for os-brick?

The last patch to land in os-brick was the one that *introduced* the regression:

https://review.opendev.org/c/openstack/os-brick/+/800014/7/os_brick/initiator/connectors/nvmeof.py#199

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-09-30: Fix proposed to os-brick (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/os-brick/+/811886

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-09-30: Change abandoned on nova (master)

Change abandoned by "Ivan Kolodyazhny <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/nova/+/811413
Reason: Will be fixed by https://review.opendev.org/c/openstack/os-brick/+/811886

Revision history for this message

Brian Rosmaita (brian-rosmaita) wrote on 2021-09-30:

Looks like the fix will be https://review.opendev.org/c/openstack/os-brick/+/811944

Changed in os-brick:
status:	Fix Committed → In Progress
importance:	Medium → Critical
milestone:	none → 5.0.1

Brian Rosmaita (brian-rosmaita) on 2021-09-30

Changed in os-brick:
assignee:	nobody → Vladislav Belogrudov (vlad-belogrudov)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-09-30: Fix proposed to os-brick (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/os-brick/+/812010

Lee Yarwood (lyarwood) on 2021-09-30

no longer affects:

nova

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-09-30: Fix merged to os-brick (master)

Reviewed: https://review.opendev.org/c/openstack/os-brick/+/811944
Committed: https://opendev.org/openstack/os-brick/commit/dd90bb6356d05a7b12198e77418befc1acc87c11
Submitter: "Zuul (22348)"
Branch: master

commit dd90bb6356d05a7b12198e77418befc1acc87c11
Author: Vladislav Belogrudov <email address hidden>
Date: Thu Sep 30 12:40:25 2021 +0300

Fix paths for NVMe devices (non-nguid)

    Fixed regression introduced by
    https://review.opendev.org/c/openstack/os-brick/+/800014, where
    connect_volume method returned a list with a single path instead of
    just the path.

Closes-Bug: #1945323
Change-Id: I5e5b13dd73ab8d30439de76dd73eb41b763e7f05

Changed in os-brick:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2021-09-30: Fix merged to os-brick (stable/xena)

#10

Reviewed: https://review.opendev.org/c/openstack/os-brick/+/812010
Committed: https://opendev.org/openstack/os-brick/commit/36f12c05a75950f8214b5504c972b98edc63cdd7
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 36f12c05a75950f8214b5504c972b98edc63cdd7
Author: Vladislav Belogrudov <email address hidden>
Date: Thu Sep 30 12:40:25 2021 +0300

Fix paths for NVMe devices (non-nguid)

    Fixed regression introduced by
    https://review.opendev.org/c/openstack/os-brick/+/800014, where
    connect_volume method returned a list with a single path instead of
    just the path.

    Closes-Bug: #1945323
    Change-Id: I5e5b13dd73ab8d30439de76dd73eb41b763e7f05
    (cherry picked from commit dd90bb6356d05a7b12198e77418befc1acc87c11)