oslo.service

Misuse of assertTrue in oslo_service/tests/test_loopingcall.py

Bug #1988308 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.service
Fix Released
Undecided
Takashi Natsume

Bug Description

The following statements in oslo_service/tests/test_loopingcall.py are useless.
They should be replaced with assertEqual.

self.assertTrue(retvalue, 'return value')

Takashi Natsume (natsume-takashi)
Changed in oslo.service:
assignee: nobody → Takashi Natsume (natsume-takashi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.service (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/oslo.service/+/855367

Changed in oslo.service:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.service (master)

Reviewed: https://review.opendev.org/c/openstack/oslo.service/+/855367
Committed: https://opendev.org/openstack/oslo.service/commit/845fc45fab4c7f273ec39ae7e696e192a5f0236b
Submitter: "Zuul (22348)"
Branch: master

commit 845fc45fab4c7f273ec39ae7e696e192a5f0236b
Author: Takashi Natsume <email address hidden>
Date: Wed Aug 31 22:02:39 2022 +0900

    Fix misuse of assertTrue

    Replace assertTrue with assertEqual.

    Change-Id: I918930a6fd3980297ee7d68dd6c9397416fb3335
    Closes-Bug: 1988308
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in oslo.service:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.service 3.1.0

This issue was fixed in the openstack/oslo.service 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.