proposed change to test-requirements breaks py34

Bug #1544377 reported by Eric Brown
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Anchor
Fix Released
Undecided
Eric Brown
Bandit
Fix Released
Critical
Eric Brown
Glance Client
Fix Released
Undecided
Eric Brown
oslo.vmware
Fix Committed
Undecided
Eric Brown

Bug Description

Patch https://review.openstack.org/#/c/278720 attempts to change test-requirements import of mock to be conditional for only 3.2 and lower. But the mock namespace in py34 is "unittest.mock" not just "mock" So this patch breaks on failing imports:

2016-02-10 23:35:34.138 | Failed to import test module: tests.unit.formatters.test_text
2016-02-10 23:35:34.138 | Traceback (most recent call last):
2016-02-10 23:35:34.138 | File "/home/jenkins/workspace/gate-bandit-python34/.tox/py34/lib/python3.4/site-packages/unittest2/loader.py", line 456, in _find_test_path
2016-02-10 23:35:34.138 | module = self._get_module_from_name(name)
2016-02-10 23:35:34.138 | File "/home/jenkins/workspace/gate-bandit-python34/.tox/py34/lib/python3.4/site-packages/unittest2/loader.py", line 395, in _get_module_from_name
2016-02-10 23:35:34.138 | __import__(name)
2016-02-10 23:35:34.139 | File "/home/jenkins/workspace/gate-bandit-python34/tests/unit/formatters/test_text.py", line 20, in <module>
2016-02-10 23:35:34.139 | import mock
2016-02-10 23:35:34.139 | ImportError: No module named 'mock'

Revision history for this message
Eric Brown (ericwb) wrote :

Doing a revert with patch: https://review.openstack.org/#/c/278814/

Changed in bandit:
assignee: nobody → Eric Brown (ericwb)
Changed in oslo.vmware:
assignee: nobody → Eric Brown (ericwb)
Changed in anchor:
assignee: nobody → Eric Brown (ericwb)
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

According to log stash more stuff failed

1. gate-aodh-docs
2. aodh-docs
3. gate-congress-python34
4. gate-cliff-python34
5. gate-os-cloud-config-python34
6. gate-anchor-python34
7. gate-bandit-python34
8. gate-murano-agent-python34
9. gate-pbr-python34
10. gate-horizon-python34

Revision history for this message
Tony Breeds (o-tony) wrote :
Eric Brown (ericwb)
Changed in bandit:
status: New → Fix Committed
Changed in anchor:
status: New → Fix Committed
Changed in oslo.vmware:
status: New → Fix Committed
Changed in python-glanceclient:
status: New → Fix Committed
assignee: nobody → Eric Brown (ericwb)
Changed in bandit:
importance: Undecided → Critical
Tim Kelsey (tim-kelsey)
Changed in bandit:
status: Fix Committed → Fix Released
Changed in anchor:
status: Fix Committed → Fix Released
Revision history for this message
Ian Cordasco (icordasc) wrote :

This fix was released in glanceclient long ago. Updating the status to reflect that

Changed in python-glanceclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.