oslotest

Stop using oslotest.mockpatch

Bug #1712017 reported by ChangBo Guo(gcb)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bilean
Fix Released
Undecided
Thomas Bechtold
oslotest
Fix Released
Undecided
Thomas Bechtold
python-heatclient
Fix Released
Low
ChangBo Guo(gcb)
python-heatclient 1.12.0

Bug Description

This module has been deprecated in favor of native fixtures in commit 5e2a84d41, need remove its usage.

http://codesearch.openstack.org/?q=from%20oslotest%20import%20mockpatch&i=nope&files=&repos=

See original description
ChangBo Guo(gcb) (glongwave)
description: updated
ChangBo Guo(gcb) (glongwave)
description: updated
Revision history for this message
Thomas Bechtold (toabctl) wrote :

tempest is not affected. it is tempest-lib which does not accept any changes...

OpenStack Infra (hudson-openstack)
Changed in python-heatclient:
assignee: nobody → Thomas Bechtold (toabctl)
status: New → In Progress
Changed in oslotest:
assignee: nobody → Thomas Bechtold (toabctl)
status: New → In Progress
Thomas Bechtold (toabctl)
Changed in tempest:
status: New → Invalid
Revision history for this message
Thomas Bechtold (toabctl) wrote :

Blazaar fixed it already with https://review.openstack.org/#/c/468984/

Changed in blazar:
status: New → Invalid
Revision history for this message
Thomas Bechtold (toabctl) wrote :

bilean is https://review.openstack.org/#/c/495794

Changed in bilean:
status: New → In Progress
assignee: nobody → Thomas Bechtold (toabctl)
Revision history for this message
ChangBo Guo(gcb) (glongwave) wrote :

I mean python-blazarclient, there is no bug track for python-blazarclient, so use Blazar bug tracking. See http://codesearch.openstack.org/?q=from%20oslotest%20import%20mockpatch&i=nope&files=&repos=

Rico Lin (rico-lin)
Changed in python-heatclient:
importance: Undecided → Critical
importance: Critical → Low
milestone: none → 1.12.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/503067

Changed in python-heatclient:
assignee: Thomas Bechtold (toabctl) → Ben Nemec (bnemec)
OpenStack Infra (hudson-openstack)
Changed in python-heatclient:
assignee: Ben Nemec (bnemec) → ChangBo Guo(gcb) (glongwave)
ChangBo Guo(gcb) (glongwave)
no longer affects: tempest
no longer affects: blazar
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-heatclient (master)

Change abandoned by Zane Bitter (<email address hidden>) on branch: master
Review: https://review.openstack.org/503067
Reason: It turns out there was an identical patch, If6406da4c940686cbda696f760d06d45690912a1, that had already got a +2, so I approved that one and we can abandon this one.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/495533
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=7ed9834e10e87d58605a5fa09ce4670d913551d8
Submitter: Zuul
Branch: master

commit 7ed9834e10e87d58605a5fa09ce4670d913551d8
Author: Thomas Bechtold <email address hidden>
Date: Sun Aug 20 08:44:19 2017 +0200

    No longer use oslotest.mockpatch

    It is deprecated[1] and will be removed soon.

    [1] I3efb3c64ebce396e756a47d110a74fe8604b6b72

    Closes-Bug: #1712017
    Change-Id: If6406da4c940686cbda696f760d06d45690912a1

Changed in python-heatclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-heatclient 1.12.0

This issue was fixed in the openstack/python-heatclient 1.12.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to bilean (master)

Reviewed: https://review.openstack.org/495794
Committed: https://git.openstack.org/cgit/openstack/bilean/commit/?id=808a5b14fc0bfff8d8c23cb4e1f125ef84de6d91
Submitter: Zuul
Branch: master

commit 808a5b14fc0bfff8d8c23cb4e1f125ef84de6d91
Author: Thomas Bechtold <email address hidden>
Date: Mon Aug 21 11:46:58 2017 +0200

    Remove deprecated oslotest.mockpatch usage

    It is deprecated[1] and will be removed soon.

    [1] https://docs.openstack.org/oslotest/latest/reference/api/oslotest.mockpatch.html

    Change-Id: I06f12724c7e64057f1c5971f4847f878a3f87a51
    Closes-Bug: #1712017

Changed in bilean:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslotest (master)

Reviewed: https://review.openstack.org/495534
Committed: https://git.openstack.org/cgit/openstack/oslotest/commit/?id=4350849eaff76700bc748d03a73c0ad43872d806
Submitter: Zuul
Branch: master

commit 4350849eaff76700bc748d03a73c0ad43872d806
Author: Thomas Bechtold <email address hidden>
Date: Sun Aug 20 08:29:08 2017 +0200

    Remove oslotest.mockpatch

    That was announced with commit 5e2a84d41. Use fixtures.Mock* classes instead.

    Closes-Bug: #1712017
    Change-Id: I367e59e7f9040cd95cb4ed8a2c3e0f526c2825ab

Changed in oslotest:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslotest 3.0.0

This issue was fixed in the openstack/oslotest 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.