Oxide

Update WebView::OpenURLFromTab for context menu interaction

Bug #1640634 reported by Chris Coulson on 2016-11-10

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Oxide	Fix Released	High	Chris Coulson	Oxide branch-1.20

Bug Description

The UbuntuWebView context menu "Open <x> in new tab/window" actions will go through this function, but it has a couple of issues:

- It DCHECK's that OpenURLParams::is_renderer_initiated is true.

- It shouldn't call WebContentsClient::ShouldCreateNewWebContents() for context menu initiated calls. We don't want the application to block these (it should create a new tab / window unconditionally)

See original description

Related branches

lp://qastaging/~oxide-developers/oxide/packaging.xenial

lp://qastaging/~oxide-developers/oxide/packaging.yakkety

lp://qastaging/~oxide-developers/oxide/packaging.xenial.overlay

lp://qastaging/~oxide-developers/oxide/packaging.vivid.overlay

lp://qastaging/~oxide-developers/oxide/packaging.trusty

lp://qastaging/~oxide-developers/oxide/packaging.zesty

Chris Coulson (chrisccoulson) on 2016-11-10

Changed in oxide:
importance:	Undecided → High
status:	New → Triaged
milestone:	none → branch-1.20
assignee:	nobody → Chris Coulson (chrisccoulson)
description:	updated