panoglview

fixup build with wxWidgets 3.0+

Bug #1810597 reported by Iouri Ivliev on 2019-01-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	panoglview	New	Undecided	Unassigned

Bug Description

A little API changes was made in wxWidgets 3.0. This patch allows to build panoglview using newer versions of toolkit.

Revision history for this message

Iouri Ivliev (lp-0o6vs1) wrote on 2019-01-05:

a patch fixing up build with wxWidgets 3.0+ Edit (8.1 KiB, text/plain)

Revision history for this message

Bruno Postle (brunopostle) wrote on 2019-01-09:

Thanks for the patch, I'll apply it.

wxwidgets 3.0 was released five years ago, I can't think of any reason why panoglview should support both wx2 and wx3. Unless you have a specific need for this I'd like to remove the wxwidgets 2.0 support from your patch.

Revision history for this message

Iouri Ivliev (lp-0o6vs1) wrote on 2019-01-10:

This patch was came from the FreeBSD port of panoglview. For now, the FreeBSD ports tree contains wxgtk versions 2.8, 3.0 and 3.1, and many ports uses wxgtk28 as a default. So I see no reason to drop the wxWidgets 2.x support while it works.
But you are the master. :)

Revision history for this message

Bruno Postle (brunopostle) wrote on 2019-01-11:

I committed the full patch, if this is what FreeBSD want then fair enough.

(Not the master :) this application has never had a maintainer, just people with commit access)