Add a setting to set the shell to launch

This needs design input. Should it be like Gnome Terminal? I'm not sure we need all those options, but I need to know how to organize them.

Can someone explain what this even means?

By default, we launch Bash, but a terminal can be made to launch other stuff.

What is the point of launching something else other than bash? Just curious.

When you say "bash" you surely mean "the user's default shell".

To change the user shell, you would usually use "chsh -s /bin/zsh". Otherwise it would not change in eg. embedded terminals or virtual consoles. However GNOME Terminal has a "custom command" option, maybe this is what's being referred to here - personally I've never had a use case for it.

Yea, if there is a system wide setting for your preferred shell, I would think we should always respect that.

But Daniel, this is a power application, and by default we'll always respect bash, just make it customizable. Even if not on the Preferences Dialog, but instead only via dconf-editor.

Re-targeting to 0.1 because of https://blueprints.launchpad.net/elementaryos/+spec/friendly-shell
Should be a dconf key, not exposed via GUI.

Christian: chsh is completely different. It changes the login shell, which handles things like system() calls etc. It's never directly exposed to the user in GUI mode. In Debian and Ubuntu it's DASH, while terminals use BASH by default. That may be either libvte or terminal setting; I'll check that out. If there's a libvte setting, this should not be done in pantheon-terminal.

Apparently it's set in an environment variable, $SHELL

Oh, wait. Looks like Christian was right after all...

I'll try setting my default shell in /etc/passwd to FISH and see if it works.

Shnatsel, how did it go?

Setting fish in /etc/passwd worked. I doubt there's an easy way to do this with libvte, so screw it.

It's actually very easy to make it customizable, just change one argument in a certain function. If people ask for it, I'll add it, but for now, it's fine.

Came to think about it, we should add this.

If it were solely my decision, I wouldn't put any preferences in pantheon-terminal at all. It seems like such a simple app that there's no need to do it. And if you know about changing shells, then you'll probably do like Christian suggested before.

I dunno, that's just my opinion.

I made some tests trying to launch "chsh -s /bin/shell" and I have to figure that commands which needs root password can't be launched well with GLib.Process.spawn_command_line so I don't know other ways to get it working

I don't think this is really relevant to launching Luna beta since it's a wish list and not a bug. Removing the luna beta milestone.

I guess I'll be using GNOME Terminal, then. I do in fact want preference settings in my terminal application: not everything should be done by messing around with config files. See iTerm on Mac OS for an example of a terminal emulator that does this well.