proliantutils

Test fails when there is internet connectivity

Bug #1779342 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
proliantutils
Fix Committed
Undecided
Unassigned

Bug Description

Hi !

proliantutils.tests.ilo.test_firmware_controller.FirmwareImageUploaderTestCase.test__get_socket_throws_exception_in_case_of_failed_connection_2 fails when there's internet connectivity. Instead of 1.1.1.1, we should use something like 198.51.100.1, which is a reserved /24 for documentation, and which therefore will always really raise a connection error. This was reported in Debian:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902241

and I wrote a patch for it, as per what's above, and that fixed the issue.

Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Hum... looks like 1.1.1.1 was already removed from the test suite. Should we re-introduce 198.51.100.1 in the test decoration?

Revision history for this message
Shivanand Tendulker (stendulker) wrote :

This has been fixed as part of https://review.openstack.org/#/c/559685/ on master branch.

Changed in proliantutils:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.