puppet-horizon

Can't customize all values of local_settings.py file

Bug #1575329 reported by Pierre Blanc
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
puppet-horizon
New
High
Unassigned

Bug Description

I would like to customize HORIZON_CONFIG["password_autocomplete"] and HORIZON_CONFIG["disable_password_reveal"]
Of course all values can't be modify on a template.
Is it possible to have a configuration provider to simplify access to each values (as ini file) for this file local_settings.py

Emilien Macchi (emilienm)
Changed in puppet-horizon:
importance: Undecided → High
Revision history for this message
David Moreau Simard (dmsimard) wrote :

Recently upstream Horizon added a key to their default configuration in:
https://github.com/openstack/horizon/blob/1b65c5369fa70bfafe95ba5ff96d64661491868c/openstack_dashboard/settings.py#L82

This broke puppet deployments of Horizon because since puppet-horizon overrides the entire HORIZON_CONFIG dict (instead of setting each individual keys), we did not have that key and it yield a Horizon KeyError exception on images_panel.

+1 for config provider or something more flexible and especially not overriding the defaults provided by upstream

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-horizon (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/841070
Committed: https://opendev.org/openstack/puppet-horizon/commit/913a2eb7664b5b64c82ed195adc1207bab446725
Submitter: "Zuul (22348)"
Branch: master

commit 913a2eb7664b5b64c82ed195adc1207bab446725
Author: Takashi Kajinami <email address hidden>
Date: Mon May 9 16:20:47 2022 +0900

    Migrate 'options' to common parameter definitions

    The options parameter is set to the same value for non-ssl vhost and
    ssl vhost. This change migrates the definition to the core parameter
    definition to define all common values in a single place.

    This also allows users to override the options parameter using
    the (ssl_)extra_params parameter.

    Related-Bug: #1575329
    Change-Id: Ifd5ffa24426f856e7d79a58085f8f703c35caf7d

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/841060
Committed: https://opendev.org/openstack/puppet-horizon/commit/963e0a96107e324c2979686c8e0f8fb36b7c0ebc
Submitter: "Zuul (22348)"
Branch: master

commit 963e0a96107e324c2979686c8e0f8fb36b7c0ebc
Author: Takashi Kajinami <email address hidden>
Date: Mon May 9 12:06:15 2022 +0900

    Support customizing log file names for apache vhosts

    ... instead of requiring the hard-coded names.

    Related-Bug: #1575329
    Change-Id: Ie3641371d3d5752115c33be50a0ab4c86989797d

Revision history for this message
Takashi Kajinami (kajinamit) wrote :

Ugh. sorry I noticed I linked a few patches to this bug accidentally. (I intended different ones which I can't find now ...)

Revision history for this message
Takashi Kajinami (kajinamit) wrote :

> This broke puppet deployments of Horizon because since puppet-horizon overrides the entire HORIZON_CONFIG dict (instead of setting each individual keys), we did not have that key and it yield a Horizon KeyError exception on images_panel.

This specific problem was resolved by https://review.opendev.org/c/openstack/puppet-horizon/+/874050

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.