keystone cannot update a password with the icehouse client

Bug #1340447 reported by Matt Fischer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-keystone
Fix Released
Undecided
Matt Fischer
Icehouse
Fix Released
Undecided
Unassigned

Bug Description

keystone's library ruby code relies on the output from keystone-client to decide if puppet should change the password. This apparently worked before, but the output has changed with newer clients.

A return of nil from this code is apparently what triggers a new password to be set:
   return nil if e.message =~ /Not Authorized/

However, newer clients do not return that string, they return:
"The request you have made requires authentication. (HTTP 401)"

The ruby code needs to be updated to handle both.

Matt Fischer (mfisch)
Changed in puppet-keystone:
assignee: nobody → Matt Fischer (mfisch)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/106250

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (master)

Reviewed: https://review.openstack.org/106250
Committed: https://git.openstack.org/cgit/stackforge/puppet-keystone/commit/?id=1e21f7cbc28adbc28089b967c253f15e1e86d75d
Submitter: Jenkins
Branch: master

commit 1e21f7cbc28adbc28089b967c253f15e1e86d75d
Author: Matt Fischer <email address hidden>
Date: Thu Jul 10 21:36:22 2014 -0600

    Fix password update for users

    Newer versions of keystone-client have changed the error message when an
    invalid password is passed in. Update the logic so that puppet can
    update passwords for users.

    Change-Id: I090f7e2ee62ee189f37921c091fe51b6d587cd74
    Closes-Bug: 1340447

Changed in puppet-keystone:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/106788

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (stable/icehouse)

Reviewed: https://review.openstack.org/106788
Committed: https://git.openstack.org/cgit/stackforge/puppet-keystone/commit/?id=10220d7ee5458fe2144e11f56e77a74afa1a79e7
Submitter: Jenkins
Branch: stable/icehouse

commit 10220d7ee5458fe2144e11f56e77a74afa1a79e7
Author: Matt Fischer <email address hidden>
Date: Thu Jul 10 21:36:22 2014 -0600

    Fix password update for users

    Newer versions of keystone-client have changed the error message when an
    invalid password is passed in. Update the logic so that puppet can
    update passwords for users.

    Change-Id: I090f7e2ee62ee189f37921c091fe51b6d587cd74
    Closes-Bug: 1340447
    (cherry picked from commit 1e21f7cbc28adbc28089b967c253f15e1e86d75d)

tags: added: in-stable-icehouse
Mathieu Gagné (mgagne)
Changed in puppet-keystone:
milestone: none → 5.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.