Activity log for bug #1409897

Date Who What changed Old value New value Message
2015-01-12 20:34:11 Mike Dorman bug added bug
2015-01-12 20:37:50 Mike Dorman bug task added puppet-neutron
2015-01-12 20:38:02 Mike Dorman bug task added puppet-glance
2015-01-12 20:51:14 OpenStack Infra puppet-nova: status New In Progress
2015-01-12 20:51:14 OpenStack Infra puppet-nova: assignee Mike Dorman (mdorman-m)
2015-01-12 20:52:42 OpenStack Infra puppet-neutron: status New In Progress
2015-01-12 20:52:42 OpenStack Infra puppet-neutron: assignee Mike Dorman (mdorman-m)
2015-01-12 20:53:47 OpenStack Infra puppet-glance: status New In Progress
2015-01-12 20:53:47 OpenStack Infra puppet-glance: assignee Mike Dorman (mdorman-m)
2015-01-12 22:07:26 Mike Dorman description Policy configuration through ::nova::policy (and similarly for the other services' modules) does not work when the Puppet future parser is enabled. This is because the internal function call API for the future parser squashes any arguments that are hashes down to "one dimensional" hashes. That breaks the data structure passed to the create_resources call, which is what actually declares the openstacklib::policy::base resources. A better solution under the future parser is using a lamba/iterator to declare the resources, rather than using create_resources. For me, personally, this applies to nova, neutron, and glance. Although I'm sure other services' modules do as well. Policy configuration through ::nova::policy (and similarly for the other services' modules) does not work because that class is not passing properly formatted data to create_resources. The comments on the ::nova::policy class indicate that the policies hash should be in this format: { 'nova-context_is_admin' => { 'context_is_admin' => 'true' }, 'nova-default' => { 'default' => 'rule:admin_or_owner' } } ... which is given directly to create_resources. However, in order for this to work properly, the hash given to create_resources should look like: { 'nova-context_is_admin' => { 'key' => 'context_is_admin', 'value' => 'true' }, 'nova-default' => { 'key' => 'default', 'value' => 'rule:admin_or_owner' } } If the user is providing a hash to ::nova::policy of the correct format, then all will be well. But if the user is providing a format as indicated in the comments, then the Puppet run will fail with: Error: Invalid parameter context_is_admin on Openstacklib::Policy::Base[nova-context_is_admin] on node xxxxx
2015-01-12 22:40:27 Mike Dorman summary policy configuration does not work with Puppet future parser policy classes parameters documentation incorrect
2015-01-12 22:41:18 Mike Dorman description Policy configuration through ::nova::policy (and similarly for the other services' modules) does not work because that class is not passing properly formatted data to create_resources. The comments on the ::nova::policy class indicate that the policies hash should be in this format: { 'nova-context_is_admin' => { 'context_is_admin' => 'true' }, 'nova-default' => { 'default' => 'rule:admin_or_owner' } } ... which is given directly to create_resources. However, in order for this to work properly, the hash given to create_resources should look like: { 'nova-context_is_admin' => { 'key' => 'context_is_admin', 'value' => 'true' }, 'nova-default' => { 'key' => 'default', 'value' => 'rule:admin_or_owner' } } If the user is providing a hash to ::nova::policy of the correct format, then all will be well. But if the user is providing a format as indicated in the comments, then the Puppet run will fail with: Error: Invalid parameter context_is_admin on Openstacklib::Policy::Base[nova-context_is_admin] on node xxxxx Policy configuration through ::nova::policy (and similarly for the other services' modules) does not work if you use the $policies parameter format as is documented in the comments. The comments on the ::nova::policy class indicate that the policies hash should be in this format: {   'nova-context_is_admin' => {     'context_is_admin' => 'true'   },   'nova-default' => {     'default' => 'rule:admin_or_owner'   } } ... which is given directly to create_resources. However, in order for this to work properly, the hash given to create_resources should look like: {   'nova-context_is_admin' => {     'key' => 'context_is_admin',     'value' => 'true'   },   'nova-default' => {     'key' => 'default',     'value' => 'rule:admin_or_owner'   } } If the user is providing a hash to ::nova::policy of the correct format, then all will be well. But if the user is providing a format as indicated in the comments, then the Puppet run will fail with: Error: Invalid parameter context_is_admin on Openstacklib::Policy::Base[nova-context_is_admin] on node xxxxx
2015-01-13 21:13:43 Emilien Macchi puppet-glance: importance Undecided Low
2015-01-13 21:13:48 Emilien Macchi puppet-neutron: importance Undecided Low
2015-01-13 21:13:50 Emilien Macchi puppet-nova: importance Undecided Low
2015-01-21 13:58:11 OpenStack Infra puppet-nova: status In Progress Fix Committed
2015-02-09 21:15:16 OpenStack Infra puppet-glance: status In Progress Fix Committed
2015-02-09 21:17:34 OpenStack Infra puppet-neutron: status In Progress Fix Committed
2015-03-26 22:39:32 Mathieu Gagné puppet-glance: milestone 6.0.0
2015-03-26 22:39:34 Mathieu Gagné puppet-neutron: milestone 6.0.0
2015-03-26 22:39:36 Mathieu Gagné puppet-nova: milestone 6.0.0
2015-06-02 03:57:41 Matt Fischer puppet-glance: status Fix Committed Fix Released
2015-06-02 03:57:42 Matt Fischer puppet-neutron: status Fix Committed Fix Released
2015-06-02 03:57:44 Matt Fischer puppet-nova: status Fix Committed Fix Released
2015-06-02 17:15:40 OpenStack Infra tags in-stable-juno
2015-07-09 18:07:13 Mathieu Gagné puppet-glance: status Fix Released Fix Committed
2015-07-09 18:07:15 Mathieu Gagné puppet-neutron: status Fix Released Fix Committed
2015-07-09 18:07:18 Mathieu Gagné puppet-nova: status Fix Released Fix Committed
2015-07-10 14:45:28 Mathieu Gagné puppet-glance: status Fix Committed Fix Released
2015-07-10 14:47:38 Mathieu Gagné puppet-nova: status Fix Committed Fix Released
2015-07-10 14:50:36 Mathieu Gagné puppet-neutron: status Fix Committed Fix Released