generic_service declares package incorrectly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
puppet-nova |
Fix Released
|
Undecided
|
Mike Dorman |
Bug Description
puppet-nova's generic_service defined type declares a package with title $nova_title. It does a check to see if the package exists in the catalog already first, but based on the title $package_name.
This results in the possibility of duplicate package declaration, or more likely, a failure on the package dependency for the service resource declared by the generic_service instance.
Example:
The spicehtml5proxy class uses the generic_service type to manage that service:
nova:
enabled => $enabled,
manage_service => $manage_service,
package_name => $::nova:
service_name => $::nova:
ensure_package => $ensure_package,
}
For EL-based distros, package_name = 'openstack-
This results in the generic_service type checking for the existence of Package[
The openstack-
I believe generic_service should define the Package with a title of $package_name, rather than $nova_title.
Changed in puppet-nova: | |
assignee: | nobody → Mike Dorman (mdorman-m) |
status: | New → In Progress |
Changed in puppet-nova: | |
status: | In Progress → Fix Committed |
Changed in puppet-nova: | |
milestone: | none → 6.0.0 |
Changed in puppet-nova: | |
status: | Fix Committed → Fix Released |
Fix proposed to branch: master /review. openstack. org/192009
Review: https:/