puppet-nova

nova conf [api]/dhcp_domain is required on nova-compute

Bug #1903908 reported by Oliver Walsh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Confirmed
Low
Unassigned
puppet-nova
Confirmed
Undecided
Oliver Walsh

Bug Description

https://review.opendev.org/480616 moved DEFAULT/dhcp_domain to [api]/dhcp_domain.

However this conf option is still required on nova-compute https://bugs.launchpad.net/tripleo/+bug/1832537/

While this is the case the DEFAULT option should be undeprecated and the [api] option deprecated.

Oliver Walsh (owalsh)
Changed in puppet-nova:
assignee: nobody → Oliver Walsh (owalsh)
affects: tripleo → nova
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-nova (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/762410

Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :

Based on the nova code and the documentation the dhcp_domain option is only used by the nova metadata service.

Do you have some logs showing how the nova-compute service fails? I tried to open the logs linked to https://bugs.launchpad.net/tripleo/+bug/1832537/ but it consistently times out for me.

Revision history for this message
sean mooney (sean-k-mooney) wrote :

it is used for the config drive that all its needed for.
specifically so we can set the hostname in the configdrive by appending the dhcp domain
https://github.com/openstack/nova/blob/7f4afc1a0fbc721731a0c88bb91cada8f4e4ed11/nova/api/metadata/base.py#L529-L535

if we dont set it on the compute hosts then it will set the host name without the domain.

Revision history for this message
Balazs Gibizer (balazs-gibizer) wrote :

@Sean: Thanks!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-nova (master)

Reviewed: https://review.opendev.org/762410
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=71276558e77c8612397d0e31187cc8eec4554ff9
Submitter: Zuul
Branch: master

commit 71276558e77c8612397d0e31187cc8eec4554ff9
Author: Oliver Walsh <email address hidden>
Date: Wed Nov 11 20:22:42 2020 +0000

    Set dhcp_domain for all nova services

    This is required for nova-compute so move to init.pp from metadata.pp and set
    DEFAULT/dhcp_domain (which nova should undeprecate) vs api/dhcp_domain.

    Change-Id: If6a26527a737a7184ebddd5b4bc346d64827e9e3
    Related-bug: #1903908
    Related-bug: #1832537

Stephen Finucane (stephenfinucane)
Changed in puppet-nova:
status: New → Confirmed
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.