puppet-watcher

The deprecated nova::api::watcher_client_password parameter should not be validated

Bug #1973316 reported by Takashi Kajinami on 2022-05-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	puppet-watcher	Fix Released	Critical	Takashi Kajinami

Bug Description

The nova::api::watcher_client_password parameter was deprecated by the following change.
https://review.opendev.org/c/openstack/puppet-watcher/+/831888

However the parameter is still validated and required.
We should not validate the parameter so that the user can use the new watcher_clients_auth instead.

Tags:

Takashi Kajinami (kajinamit) on 2022-05-13

Changed in puppet-watcher:
importance:	Undecided → Critical
assignee:	nobody → Takashi Kajinami (kajinamit)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-05-13: Fix proposed to puppet-watcher (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/puppet-watcher/+/841723

Changed in puppet-watcher:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-05-13: Related fix proposed to puppet-watcher (stable/yoga)

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/puppet-watcher/+/841724

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-05-18: Fix merged to puppet-watcher (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/puppet-watcher/+/841723
Committed: https://opendev.org/openstack/puppet-watcher/commit/84f1325e7911d8a6f1a6743206286564b31791ac
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 84f1325e7911d8a6f1a6743206286564b31791ac
Author: Takashi Kajinami <email address hidden>
Date: Fri May 13 20:49:11 2022 +0900

Do not validate the deprecated parameter

    The watcher::api::watcher_client_password parameter was deprecated
    during Yoga cycle in favor of the new watcher::watcher_clients_auth
    class[1]. Thus the parameter should not be validated.

[1] 16bcc44238bd018c527c87c4cd0542f5cadc5774

    Closes-Bug: #1973316
    Change-Id: Ied515e3ba52d9fb9bd96ea24149fa7f6c44db9c5
    (cherry picked from commit 858c3d50e4c6a85c7bf5cddc638be7a2978e09e5)

tags:

added: in-stable-yoga

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-05-18: Related fix merged to puppet-watcher (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/puppet-watcher/+/841724
Committed: https://opendev.org/openstack/puppet-watcher/commit/5580521bd1404147ad20f9e1e4304035d5597c62
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 5580521bd1404147ad20f9e1e4304035d5597c62
Author: Takashi Kajinami <email address hidden>
Date: Fri May 13 21:06:07 2022 +0900

Prepare a new stable/yoga release

... to create a new release which includes the fix for bug 1973316.

Related-Bug: #1973316
Change-Id: I32beb5ed22aa60426dea3c594e700a12cddf31e7

Changed in puppet-watcher:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-05-18: Fix merged to puppet-watcher (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-watcher/+/841720
Committed: https://opendev.org/openstack/puppet-watcher/commit/858c3d50e4c6a85c7bf5cddc638be7a2978e09e5
Submitter: "Zuul (22348)"
Branch: master

commit 858c3d50e4c6a85c7bf5cddc638be7a2978e09e5
Author: Takashi Kajinami <email address hidden>
Date: Fri May 13 20:49:11 2022 +0900

Do not validate the deprecated parameter

    The watcher::api::watcher_client_password parameter was deprecated
    during Yoga cycle in favor of the new watcher::watcher_clients_auth
    class[1]. Thus the parameter should not be validated.

[1] 16bcc44238bd018c527c87c4cd0542f5cadc5774

Closes-Bug: #1973316
Change-Id: Ied515e3ba52d9fb9bd96ea24149fa7f6c44db9c5

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-05-19: Fix included in openstack/puppet-watcher 20.3.1

This issue was fixed in the openstack/puppet-watcher 20.3.1 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-10-20: Fix included in openstack/puppet-watcher 21.0.0

This issue was fixed in the openstack/puppet-watcher 21.0.0 release.