weak error message testing
Bug #831883 reported by
William Reade
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pyjuju |
Fix Released
|
Undecided
|
William Reade | ||
Bug Description
In lots of places, we use .assertIn rather than .assertEquals when testing error messages, and this contributes to poor-quality messages. I don't think assertEquals is *always* the right approach, but we should use it more than we do.
Related branches
lp://qastaging/~fwereade/pyjuju/cobbler-zk-connect-error-messages
- Jim Baker (community): Approve
- Gustavo Niemeyer (community): Approve
-
Diff: 1156 lines (+192/-174)43 files modifiedensemble/agents/provision.py (+4/-4)
ensemble/agents/tests/test_provision.py (+3/-3)
ensemble/agents/tests/test_unit.py (+4/-4)
ensemble/control/status.py (+3/-3)
ensemble/control/tests/test_status.py (+0/-2)
ensemble/errors.py (+7/-19)
ensemble/formula/bundle.py (+3/-3)
ensemble/formula/provider.py (+1/-1)
ensemble/formula/tests/test_bundle.py (+8/-4)
ensemble/formula/tests/test_config.py (+6/-4)
ensemble/formula/tests/test_repository.py (+4/-4)
ensemble/hooks/tests/test_arguments.py (+2/-2)
ensemble/hooks/tests/test_cli.py (+5/-2)
ensemble/hooks/tests/test_executor.py (+1/-1)
ensemble/hooks/tests/test_invoker.py (+1/-1)
ensemble/lib/tests/test_schema.py (+1/-1)
ensemble/machine/tests/test_unit_deployment.py (+6/-4)
ensemble/machine/unit.py (+1/-1)
ensemble/providers/common/connect.py (+2/-2)
ensemble/providers/common/findzookeepers.py (+1/-1)
ensemble/providers/common/tests/test_connect.py (+5/-7)
ensemble/providers/common/tests/test_findzookeepers.py (+27/-2)
ensemble/providers/common/tests/test_utils.py (+2/-5)
ensemble/providers/common/utils.py (+3/-1)
ensemble/providers/ec2/__init__.py (+3/-2)
ensemble/providers/ec2/launch.py (+2/-3)
ensemble/providers/ec2/securitygroup.py (+6/-7)
ensemble/providers/ec2/tests/common.py (+0/-10)
ensemble/providers/ec2/tests/test_connect.py (+5/-7)
ensemble/providers/ec2/tests/test_getmachines.py (+2/-3)
ensemble/providers/ec2/tests/test_launch.py (+3/-4)
ensemble/providers/ec2/tests/test_provider.py (+4/-1)
ensemble/providers/ec2/tests/test_securitygroup.py (+6/-6)
ensemble/providers/orchestra/cobbler.py (+5/-5)
ensemble/providers/orchestra/tests/test_cobbler.py (+14/-9)
ensemble/providers/orchestra/tests/test_connect.py (+4/-4)
ensemble/providers/orchestra/tests/test_launch.py (+14/-6)
ensemble/providers/orchestra/tests/test_provider.py (+4/-2)
ensemble/state/service.py (+2/-1)
ensemble/state/tests/test_security.py (+1/-1)
ensemble/state/tests/test_service.py (+9/-5)
ensemble/tests/test_errors.py (+6/-16)
ensemble/unit/tests/test_formula.py (+2/-1)
| Changed in ensemble: | |
| assignee: | nobody → William Reade (fwereade) |
| milestone: | none → eureka |
| Changed in ensemble: | |
| status: | New → In Progress |
| Changed in ensemble: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
