revision in charm's metadata.yaml is inconvenient
Bug #867877 reported by
William Reade
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pyjuju |
Fix Released
|
Undecided
|
William Reade | ||
Bug Description
Imminent plans to automatically update charms' revisions are made somewhat tricky by the fact that, to do so, we'd have to load-modify-dump metadata.yaml, thereby losing comments (and potentially altering the file's structure, making real changes harder to keep track of). Therefore, we should keep charms' revisions in files called "revision", containing nothing but the revision.
However, we can't afford to spring another breaking change on everybody, so we still have to allow charms with the revision specified in the old format, while encouraging people to use the new format.
Related branches
lp://qastaging/~fwereade/pyjuju/isolate-formula-revisions
- Kapil Thangavelu (community): Approve
- Gustavo Niemeyer: Approve
-
Diff: 1114 lines (+346/-144)43 files modifiedexamples/oneiric/mysql/metadata.yaml (+0/-1)
examples/oneiric/mysql/revision (+1/-0)
examples/oneiric/php/metadata.yaml (+0/-1)
examples/oneiric/php/revision (+1/-0)
examples/oneiric/wordpress/metadata.yaml (+0/-1)
examples/oneiric/wordpress/revision (+1/-0)
juju/agents/tests/test_machine.py (+1/-1)
juju/agents/tests/test_unit.py (+2/-2)
juju/charm/base.py (+31/-0)
juju/charm/bundle.py (+19/-16)
juju/charm/directory.py (+23/-4)
juju/charm/metadata.py (+13/-6)
juju/charm/repository.py (+5/-5)
juju/charm/tests/__init__.py (+1/-1)
juju/charm/tests/repository/series/dummy/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/dummy/revision (+1/-0)
juju/charm/tests/repository/series/mysql-alternative/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/mysql-alternative/revision (+1/-0)
juju/charm/tests/repository/series/mysql/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/mysql/revision (+1/-0)
juju/charm/tests/repository/series/new/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/new/revision (+1/-0)
juju/charm/tests/repository/series/old/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/old/revision (+1/-0)
juju/charm/tests/repository/series/riak/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/riak/revision (+1/-0)
juju/charm/tests/repository/series/varnish-alternative/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/varnish-alternative/revision (+1/-0)
juju/charm/tests/repository/series/varnish/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/varnish/revision (+1/-0)
juju/charm/tests/repository/series/wordpress/metadata.yaml (+0/-1)
juju/charm/tests/repository/series/wordpress/revision (+1/-0)
juju/charm/tests/test_base.py (+42/-16)
juju/charm/tests/test_bundle.py (+60/-21)
juju/charm/tests/test_directory.py (+62/-4)
juju/charm/tests/test_metadata.py (+33/-19)
juju/charm/tests/test_repository.py (+31/-24)
juju/control/deploy.py (+1/-1)
juju/control/tests/test_upgrade_charm.py (+8/-8)
juju/machine/tests/test_unit_deployment.py (+1/-1)
juju/state/charm.py (+0/-1)
juju/state/tests/test_charm.py (+0/-1)
juju/unit/tests/test_charm.py (+1/-1)
| Changed in juju: | |
| status: | New → In Progress |
| assignee: | nobody → William Reade (fwereade) |
| milestone: | none → eureka |
| Changed in juju: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
