python-heatclient

logical_resource_id disappeared in favor of resource_name

Bug #1216903 reported by Swann Croiset
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Steve Baker
OpenStack Dashboard (Horizon) 2013.2 "havana"
python-heatclient
Fix Released
High
Swann Croiset
python-heatclient v0.2.5
tempest
Fix Released
Undecided
Steve Baker

Bug Description

impact from Heat side :

https://review.openstack.org/#/c/43391/

Swann Croiset (swann-w)
Changed in python-heatclient:
assignee: nobody → Swann Croiset (swann-w)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43704

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/43704
Committed: http://github.com/openstack/python-heatclient/commit/6f99131805eafa2965a08d498fd6816c60ed935f
Submitter: Jenkins
Branch: master

commit 6f99131805eafa2965a08d498fd6816c60ed935f
Author: Swann Croiset <email address hidden>
Date: Mon Aug 26 15:08:05 2013 +0200

    Rename event logical_resource_id to resource_name

    Required by Heat change (https://review.openstack.org/#/c/43391/)

    fixe bug #1216903

    Change-Id: I77201348df401d5bafc7109bb4d032dd071468d8

Steve Baker (steve-stevebaker)
Changed in python-heatclient:
importance: Undecided → High
status: New → Fix Committed
milestone: none → v0.2.5
Changed in tempest:
assignee: nobody → Steve Baker (steve-stevebaker)
Changed in horizon:
assignee: nobody → Steve Baker (steve-stevebaker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43818

Changed in horizon:
status: New → In Progress
Changed in tempest:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/43819

David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → High
milestone: none → havana-3
Revision history for this message
Steve Baker (steve-stevebaker) wrote :

I've re-opened this for python-heatclient since the committed fix https://review.openstack.org/#/c/43704 has an issue

heatclient needs to be backwards compatible with (ideally) all previous versions of heat. With this change it will now cease to display the logical_resource_id if that is all is returned by the API.

The fix would be to check the returned resource/events to see if they have a resource_name, and revert to presenting logical_resource_id if necessary.

Changed in python-heatclient:
status: Fix Committed → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/43818
Committed: http://github.com/openstack/horizon/commit/c208701f58903163245789fe2bc6bcbe77db0164
Submitter: Jenkins
Branch: master

commit c208701f58903163245789fe2bc6bcbe77db0164
Author: Steve Baker <email address hidden>
Date: Tue Aug 27 14:13:56 2013 +1200

    Rename heat logical_resource_id to resource_name

    This attribute has been renamed in the heat API.

    Fixes bug: 1216903

    Change-Id: Ia29c0d1a7af8988cf69094bdfbdd7f439078dc7e

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/43819
Committed: http://github.com/openstack/tempest/commit/33d8e93143046f1d6790e5c0aa35bc941f893fb5
Submitter: Jenkins
Branch: master

commit 33d8e93143046f1d6790e5c0aa35bc941f893fb5
Author: Steve Baker <email address hidden>
Date: Tue Aug 27 14:16:40 2013 +1200

    Rename heat logical_resource_id to resource_name

    This attribute has been renamed in the heat API.

    Fixes bug: 1216903

    Change-Id: I4b3b65564eed08d0e077302e747f5ea1124ff7d6

Changed in tempest:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44295

Changed in python-heatclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/44295
Committed: http://github.com/openstack/python-heatclient/commit/b95657fd15e8e1880978a130c4faa45b290397a8
Submitter: Jenkins
Branch: master

commit b95657fd15e8e1880978a130c4faa45b290397a8
Author: Swann Croiset <email address hidden>
Date: Thu Aug 29 15:47:22 2013 +0200

    Be backward compatible after a renaming in API

    The need was introduced with the renaming of field logical_resource_id
    to resource_name, so let heatclient display the good one for the two
    Heat versions.

    Fixes bug #1216903

    Change-Id: I3e86f482a1b814a27b15be3c102727c44153221f

Changed in python-heatclient:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Steve Baker (steve-stevebaker)
Changed in python-heatclient:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: havana-3 → 2013.2
Sean Dague (sdague)
Changed in tempest:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.