Environment registry urls must be absolute

Bug #1233912 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-heatclient
Fix Released
High
Steve Baker

Bug Description

Requiring absolute URLs in a local environment's resource registry limits the usefulness of this feature. Most users will want to specify a relative path to a file in the same directory as the environment file.

Changed in python-heatclient:
status: New → Triaged
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50205

Changed in python-heatclient:
assignee: nobody → Steve Baker (steve-stevebaker)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/50205
Committed: http://github.com/openstack/python-heatclient/commit/8b35d094ba0f05d5921ab56531bb7bf50a75347f
Submitter: Jenkins
Branch: master

commit 8b35d094ba0f05d5921ab56531bb7bf50a75347f
Author: Steve Baker <email address hidden>
Date: Tue Oct 8 13:36:10 2013 +1300

    Allow env registry paths to be relative to env file

    The default base_url is now derived from the location
    of the environment file, so now resource registry paths
    can be relative instead of absolute URLs.

    This change also includes the following:
    * more complete test coverage
    * refactor of _process_environment_and_files and
      _get_file_contents to make test coverage easier
    * use the full URL instead of just the file name in the
      'files' field to avoid key clashes
    * make _get_file_contents less specific to the resource registry
      so it can be used for other inclusion tasks
    * stop calling _get_file_contents recursively so that deep URLs
      do not get loaded, instead call _get_file_contents on
      resource_registry and resource_registry.resources.*
    Closes-Bug: #1233912

    Change-Id: Ic729cbcd1711b89e91daf0d645f4f56bae2accf3

Changed in python-heatclient:
status: In Progress → Fix Committed
Changed in python-heatclient:
milestone: none → v0.2.6
Changed in python-heatclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.