remove python 2.5 support for parse_sql

Bug #1243418 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-heatclient
Fix Released
Low
Kui Shi

Bug Description

Python 2.5 is not supported anymore, remove the obsolete code in heatclient/common/http.py.

Revision history for this message
Kui Shi (skuicloud) wrote :

diff --git a/heatclient/common/http.py b/heatclient/common/http.py
index c9fa89c..2b18c07 100644
--- a/heatclient/common/http.py
+++ b/heatclient/common/http.py
@@ -32,11 +32,6 @@ try:
 except ImportError:
     import simplejson as json

-# Python 2.5 compat fix
-if not hasattr(urlutils, 'parse_qsl'):
- import cgi
- urlutils.parse_qsl = cgi.parse_qsl
-

 from heatclient import exc

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/53230

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/53230
Committed: http://github.com/openstack/python-heatclient/commit/c27fc77fe247915d11547f482370e4e133962eee
Submitter: Jenkins
Branch: master

commit c27fc77fe247915d11547f482370e4e133962eee
Author: Kui Shi <email address hidden>
Date: Tue Oct 22 15:46:02 2013 +0800

    remove python 2.5 support for parse_sql

    Python 2.5 is not supported anymore, remove the obsolete code for parse_sql.

    Close-Bug #1243418

    Change-Id: Ib87bde26a9b44555a36e3831f6aa33a6b3a4ba21

Revision history for this message
Angus Salkeld (asalkeld) wrote :

Next time use:
Closes-Bug #1243418
not:
Close-Bug #1243418

(don't stress I also make the mistake sometimes)

This has been committed.

Changed in python-heatclient:
assignee: nobody → Kui Shi (skuicloud)
status: New → Fix Committed
importance: Undecided → Low
Revision history for this message
Kui Shi (skuicloud) wrote :

Go it, thanks for your kindly reminder.

Changed in python-heatclient:
milestone: none → v0.2.6
Changed in python-heatclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.