Tests broken in master

Bug #1252313 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-heatclient
Fix Released
High
Steven Hardy

Bug Description

For some reason, the gate failed to detect that the patch merged for bug #1248265 breaks the tests. It also doesn't actually fix the auth_token issues, ref bug #1252248 so we may as well revert it and I'll propose a proper fix for the auth_token issues via bug #1252248

======================================================================
FAIL: heatclient.tests.test_shell.ShellParamValidationTest.test_no_token_no_password(create)
tags: worker-1
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 171, in test_no_token_no_password
    self.shell_error(cmd, err)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 71, in shell_error
    self.assertRegexpMatches(e.__str__(), error_match)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 62, in assertRegexpMatches
    raise self.failureException(msg)
AssertionError: Regexp didn't match: 'You must provide a password or auth token.' not found in "Unexpected method call Client.__call__(auth_url='http://no.where', insecure=False, password='8ded442662f74c55', tenant_id='', tenant_name='tenant_name', username='username') -> None"
======================================================================
FAIL: heatclient.tests.test_shell.ShellParamValidationTest.test_no_token_no_password(stack-update)
tags: worker-1
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 171, in test_no_token_no_password
    self.shell_error(cmd, err)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 71, in shell_error
    self.assertRegexpMatches(e.__str__(), error_match)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 62, in assertRegexpMatches
    raise self.failureException(msg)
AssertionError: Regexp didn't match: 'You must provide a password or auth token.' not found in "Unexpected method call Client.__call__(auth_url='http://no.where', insecure=False, password='8ded442662f74c55', tenant_id='', tenant_name='tenant_name', username='username') -> None"
======================================================================
FAIL: heatclient.tests.test_shell.ShellParamValidationTest.test_no_token_no_password(template-validate)
tags: worker-2
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 171, in test_no_token_no_password
    self.shell_error(cmd, err)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 71, in shell_error
    self.assertRegexpMatches(e.__str__(), error_match)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 62, in assertRegexpMatches
    raise self.failureException(msg)
AssertionError: Regexp didn't match: 'You must provide a password or auth token.' not found in "Unexpected method call Client.__call__(auth_url='http://no.where', insecure=False, password='8ded442662f74c55', tenant_id='', tenant_name='tenant_name', username='username') -> None"
======================================================================
FAIL: heatclient.tests.test_shell.ShellParamValidationTest.test_no_token_no_password(validate)
tags: worker-1
----------------------------------------------------------------------
traceback-1: {{{
Traceback (most recent call last):
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 171, in test_no_token_no_password
    self.shell_error(cmd, err)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 71, in shell_error
    self.assertRegexpMatches(e.__str__(), error_match)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 62, in assertRegexpMatches
    raise self.failureException(msg)
AssertionError: Regexp didn't match: 'You must provide a password or auth token.' not found in "Unexpected method call Client.__call__(auth_url='http://no.where', insecure=False, password='8ded442662f74c55', tenant_id='', tenant_name='tenant_name', username='username') -> None"
}}}
======================================================================
FAIL: heatclient.tests.test_shell.ShellParamValidationTest.test_no_token_no_password(stack-create)
tags: worker-3
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 171, in test_no_token_no_password
    self.shell_error(cmd, err)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 71, in shell_error
    self.assertRegexpMatches(e.__str__(), error_match)
  File "/home/shardy/git/python-heatclient/heatclient/tests/test_shell.py", line 62, in assertRegexpMatches
    raise self.failureException(msg)
AssertionError: Regexp didn't match: 'You must provide a password or auth token.' not found in "Unexpected method call Client.__call__(auth_url='http://no.where', insecure=False, password='8ded442662f74c55', tenant_id='', tenant_name='tenant_name', username='username') -> None"
======================================================================

Steven Hardy (shardy)
Changed in python-heatclient:
assignee: nobody → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/56959

Changed in python-heatclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/56959
Committed: http://github.com/openstack/python-heatclient/commit/1f388064fb0120c9614c8ea2684e4fae51a2587f
Submitter: Jenkins
Branch: master

commit 1f388064fb0120c9614c8ea2684e4fae51a2587f
Author: Steven Hardy <email address hidden>
Date: Mon Nov 18 15:24:22 2013 +0000

    Revert "heatclient is not working with os-auth-token"

    This reverts commit 4eab568f79bdbfe4ba0d31038bf3c253d0858c59.

    The commit breaks the unit tests (and for some reason still passed
    the gate...?), and also doesn't fix the issues with auth_token, ref
    bug #1252248. So revert this patch, while I work on a more
    comprehensive fix to the auth_token issues.

    Change-Id: I34b9e808928d091384c4c466f14260252a45fd2e
    Closes-Bug: 1252313

Changed in python-heatclient:
status: In Progress → Fix Committed
Changed in python-heatclient:
importance: Undecided → High
milestone: none → v0.2.6
Changed in python-heatclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.