python-ironicclient

command-line shell lacks unit tests

Bug #1235431 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-ironicclient
Fix Released
Wishlist
sonu
python-ironicclient 0.8.0 "0.8.0"

Bug Description

As per comments on https://review.openstack.org/#/c/49538/, the command line shell currently doesn't have any unit tests.

aeva black (tenbrae)
Changed in python-ironicclient:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

I was working on shell tests for neutron client so I can help with porting them to Ironic client

Revision history for this message
Lucas Alvares Gomes (lucasagomes) wrote :

@Roman, that would be great :)

Lucas Alvares Gomes (lucasagomes)
Changed in python-ironicclient:
assignee: Lucas Alvares Gomes (lucasagomes) → nobody
aeva black (tenbrae)
Changed in python-ironicclient:
importance: High → Low
aeva black (tenbrae)
Changed in python-ironicclient:
importance: Low → Wishlist
sonu (sonu-bhumca11)
Changed in python-ironicclient:
assignee: nobody → sonu (sonu-bhumca11)
Revision history for this message
Rakesh H S (rh-s) wrote :

Hi Sonu,

I am working on https://bugs.launchpad.net/python-ironicclient/+bug/1436440 which in turn required adding unit tests.
Can you transfer this bug to me?
However, If you have already started on this, I can wait for your patch to land and then do the changes required for 1436440.

Regards

Revision history for this message
sonu (sonu-bhumca11) wrote :

Hi Rakesh,

    I have already started working on this bug and will soon submit the patch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/172371

Changed in python-ironicclient:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/180396

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-ironicclient (master)

Change abandoned by sonu (<email address hidden>) on branch: master
Review: https://review.openstack.org/180396
Reason: mistakenly commited with new change id.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/172371
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=fdcfc6050c8ea3acfa5e2b9484fbde71a7ced9bd
Submitter: Jenkins
Branch: master

commit fdcfc6050c8ea3acfa5e2b9484fbde71a7ced9bd
Author: sonu.kumar <email address hidden>
Date: Mon Aug 3 19:27:01 2015 +0530

    Added unit tests for command-line shell

    Ironic client lacks unit test for shell. These unit tests have been
    added in this patch

    Closes-Bug: #1235431

    Change-Id: I29686ed355baae6fc9c6ad4122688c14601f2398

Changed in python-ironicclient:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in python-ironicclient:
milestone: none → 0.8.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.