python-ironicclient

default timeout is missed in requests session which may hung forever

Bug #1730618 reported by Vasyl Saienko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Invalid
Medium
Boushra Sondos Bettir
ironic-python-agent
Fix Released
Medium
Vasyl Saienko
python-ironicclient
Triaged
Medium
Unassigned

Bug Description

We should specify default timeout to each request session because if timeout is not set, request may hung, as it is not limited in time by default http://docs.python-requests.org/en/master/user/quickstart/#timeouts

One of examples is https://github.com/openstack/ironic-python-agent/blob/fd7f10b993ef5262e76d604b38cfad25aed2266d/ironic_python_agent/ironic_api_client.py#L64

Vasyl Saienko (vsaienko)
Changed in ironic:
assignee: nobody → Vasyl Saienko (vsaienko)
Changed in ironic-python-agent:
assignee: nobody → Vasyl Saienko (vsaienko)
Vladyslav Drok (vdrok)
Changed in ironic:
importance: Undecided → Medium
Changed in ironic-python-agent:
importance: Undecided → Medium
Changed in ironic:
status: New → Triaged
Changed in ironic-python-agent:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-python-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/518322

Changed in ironic-python-agent:
status: Triaged → In Progress
Revision history for this message
Vasyl Saienko (vsaienko) wrote :

ironicclient also affected, any api request may hung forever when API is not available
$ date; ironic --ironic-url http://5.2.3.4 node-list
Wed Nov 15 09:14:00 UTC 2017
The "ironic" CLI is deprecated and will be removed in the S* release. Please use the "openstack baremetal" CLI instead.
^C... terminating ironic client
$ date
Wed Nov 15 09:15:50 UTC 2017
$

no longer affects: python-ironicclient (Ubuntu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ironicclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/520056

Changed in python-ironicclient:
assignee: nobody → Vasyl Saienko (vsaienko)
status: New → In Progress
Dmitry Tantsur (divius)
Changed in python-ironicclient:
importance: Undecided → Medium
Dmitry Tantsur (divius)
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/537311

Changed in ironic:
assignee: Vasyl Saienko (vsaienko) → ya.wang (ya.wang)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by ya.wang (wang.ya@99cloud.net) on branch: master
Review: https://review.openstack.org/537311

Revision history for this message
Jay Faulkner (jason-oldos) wrote :

https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/ironic_api_client.py#L85

This functionality is in IPA now.

Changed in python-ironicclient:
status: In Progress → Invalid
Changed in ironic:
status: In Progress → Won't Fix
Changed in ironic-python-agent:
status: In Progress → Fix Released
Changed in ironic:
status: Won't Fix → Invalid
Changed in python-ironicclient:
status: Invalid → Triaged
Revision history for this message
Jay Faulkner (jason-oldos) wrote :

Looks like we still have some missing timeouts in python-ironicclient:
- https://github.com/openstack/python-ironicclient/blob/1a11b9c463bb68aed2f37c9c1ff74e86c6aa294c/ironicclient/common/http.py#L377C31
(not comprehensive list)

Jay Faulkner (jason-oldos)
Changed in ironic:
assignee: ya.wang (ya.wang) → nobody
Changed in python-ironicclient:
assignee: Vasyl Saienko (vsaienko) → nobody
Boushra Sondos Bettir (boushrabettir04)
Changed in ironic:
assignee: nobody → Boushra Sondos Bettir (boushrabettir04)
Changed in python-ironicclient:
assignee: nobody → Boushra Sondos Bettir (boushrabettir04)
Jay Faulkner (jason-oldos)
Changed in python-ironicclient:
assignee: Boushra Sondos Bettir (boushrabettir04) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.