lack of unittests

Bug #1364800 reported by Valeriy Ponomaryov
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-manilaclient
In Progress
Low
Alexander Pugachev

Bug Description

Manilaclient has to small test coverage. It should be improved.

Changed in python-manilaclient:
importance: Undecided → Medium
Changed in python-manilaclient:
importance: Medium → Low
Changed in python-manilaclient:
importance: Low → Wishlist
Changed in python-manilaclient:
assignee: nobody → Michael Glaser (mikeg451)
Revision history for this message
Michael Glaser (mikeg451) wrote :

Haven't had time to work on bug, so want to release for someone else to work on.

Changed in python-manilaclient:
assignee: Michael Glaser (mikeg451) → nobody
Changed in python-manilaclient:
assignee: nobody → Alexander Pugachev (a-pugachev-wd)
Changed in python-manilaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/404167

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/404167
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=a6d071e0966ee835549e7f2335a5852b1c54b997
Submitter: Jenkins
Branch: master

commit a6d071e0966ee835549e7f2335a5852b1c54b997
Author: Alexander Pugachev <email address hidden>
Date: Tue Nov 29 11:28:07 2016 +0000

    Configures coverage tool

    Section "coverage:run" is translated to section "run" of coverage config.
    Excluding tests itself from coverage, adding branches to have wide picture.

    Change-Id: I4474773837128ec5683a6da2655b055d28850ad4
    Partial-Bug: #1364800

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/482108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/482108
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=ec8620a4e2bc4e62e75df8b9608fca84ad99af2c
Submitter: Jenkins
Branch: master

commit ec8620a4e2bc4e62e75df8b9608fca84ad99af2c
Author: Alexander Pugachev <email address hidden>
Date: Mon Jul 10 12:37:28 2017 +0100

    Increases code coverage

    Covers manilaclient/common/apiclient/auth.py:discover_auth_systems().

    Coverage for manilaclient/common/apiclient/auth.py goes from 0% to 35%.
    Overall coverage goes from 71% to 74%.

    Change-Id: I685051bbe3e0f82e69efef7d25aa42e385acc3f9
    Partial-Bug: #1364800

Changed in python-manilaclient:
status: In Progress → Fix Released
Changed in python-manilaclient:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/513433

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/514964

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/516804

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/513433
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=784f9cc63baa0535ca75672d185eca37f88316cc
Submitter: Zuul
Branch: master

commit 784f9cc63baa0535ca75672d185eca37f88316cc
Author: Alexander Pugachev <email address hidden>
Date: Tue Oct 17 16:01:38 2017 +0100

    Increase code coverage

    Covers v2/shell.py:do_share_replica_delete().

    This change removes unused branching and extends coverage by testing
    raising errors when all replicas deletion failed.

    The argument --force can never be None due to action 'store_true'.

    Change-Id: I6eeb39921fe032688c172a0666f089ab12afe4c1
    Partial-Bug: #1364800

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/514964
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=7284e58e741e35c833997691dd93549e7cf0126c
Submitter: Zuul
Branch: master

commit 7284e58e741e35c833997691dd93549e7cf0126c
Author: Alexander Pugachev <email address hidden>
Date: Wed Oct 25 09:59:44 2017 +0100

    Increase code coverage

    Covers v2/shell.py:do_message_delete().

    This change checks for raising an error only if all messages
    failed to be found (or deleted).

    Change-Id: I838fdbc7904220f3139f284746ddb859b434066c
    Partial-Bug: #1364800

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/537317

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/537319

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/537819

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/537317
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=635dd032fa5f28e678bd1bb520f4a08af56ce860
Submitter: Zuul
Branch: master

commit 635dd032fa5f28e678bd1bb520f4a08af56ce860
Author: Alexander Pugachev <email address hidden>
Date: Tue Jan 23 09:54:08 2018 +0000

    Cover string representations of api_versions.APIVersion

    Adding unit-tests to check string representation and repr()
    results for api_versions.APIVersion instances.
    Both for valid versions and null.

    This increases code coverage.

    Change-Id: I53125c0f993a54812d47341c7956222b7da65c7f
    Partial-Bug: #1364800

Changed in python-manilaclient:
assignee: Alexander Pugachev (a-pugachev-wd) → Tom Barron (tpb)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/537319
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=791b9f4a81e2ab337156653f5391eafb34e18d46
Submitter: Zuul
Branch: master

commit 791b9f4a81e2ab337156653f5391eafb34e18d46
Author: Alexander Pugachev <email address hidden>
Date: Wed Jan 24 09:26:49 2018 +0000

    Add missing assertions for APIVersion comparison

    The test already had the assertion for __lt__ methods.
    Adding assertions for __eq__ and __gt__ methods.

    This insreases code coverage.

    Change-Id: I544cd61a7028421986df961eaa3af2155137ab5a
    Partial-Bug: #1364800

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/537819
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=e20171bf66358c3e1ae6a5873059d026bf892df1
Submitter: Zuul
Branch: master

commit e20171bf66358c3e1ae6a5873059d026bf892df1
Author: Alexander Pugachev <email address hidden>
Date: Wed Jan 24 09:47:18 2018 +0000

    Add unit-test for apiversions.APIVersion.is_latest

    The method was not covered.

    Change-Id: I2376a2e948445ca532f3126cc5570bab2544e7b4
    Partial-Bug: #1364800

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/569776

Changed in python-manilaclient:
assignee: Tom Barron (tpb) → junboli (junboli)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/569776
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=d6ea79fa64a22129d0c9cde3c17c39759b01adce
Submitter: Zuul
Branch: master

commit d6ea79fa64a22129d0c9cde3c17c39759b01adce
Author: junboli <email address hidden>
Date: Mon May 21 18:51:25 2018 +0800

    Increase coverage test

    Add manila v2 limit unittest to increase coverage
    test.

    Change-Id: I0c8e0fa78bac8ec87e5bc3235d7e66d7b2a3a864
    Partial-Bug: #1364800

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/608197

Changed in python-manilaclient:
assignee: junboli (junboli) → Alexander Pugachev (a-pugachev-wd)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/608197
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=522b712a1539aed41fc96e65fcedf2db650b6f50
Submitter: Zuul
Branch: master

commit 522b712a1539aed41fc96e65fcedf2db650b6f50
Author: Alexander Pugachev <email address hidden>
Date: Fri Oct 5 10:37:52 2018 +0100

    Add unit-test for availability_zones.AvailabilityZone repr()

    The method was not covered.

    Change-Id: I2fb3e9cc33201363087ba33876fe36dd515b9123
    Partial-Bug: #1364800

Changed in python-manilaclient:
importance: Wishlist → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.