python-manilaclient

Functional tests that are skipped appear as failures

Bug #1849728 reported by Goutham Pacha Ravi on 2019-10-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-manilaclient	Fix Released	Critical	Douglas Viroel	python-manilaclient ussuri-1

Bug Description

This bug may be a fallout from https://bugs.launchpad.net/tempest/+bug/1847749

The fix for LP 1847749 was committed in two parts: https://review.opendev.org/#/c/681340/ and https://review.opendev.org/#/c/687999/; however, a lot of manilaclient functional tests are still being marked as failed when they raise a "SkipException".

The test jobs do not capture sufficient logs to triage directly, but, from the HTML output from testr:

test_create_delete_cert_access_rule_2_2_0
fail
[x]

ft1.3: manilaclient.tests.functional.test_share_access.CIFSShareRWAccessReadWriteTest.test_create_delete_cert_access_rule_2_2_0testtools.testresult.real._StringException

The console output has been attached to this bug. This failure is observed when using tempest==22.1.0 from PyPi.

Tags:

Revision history for this message

Goutham Pacha Ravi (gouthamr) wrote on 2019-10-24:

python-manilaclient-job-output.txt Edit (848.6 KiB, text/plain)

OpenStack Infra (hudson-openstack) on 2019-10-28

Changed in python-manilaclient:
assignee:	nobody → Douglas Viroel (dviroel)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-10-30: Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/691116
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=0ca91287acffece4f78451e160fafa040a988f5a
Submitter: Zuul
Branch: master

commit 0ca91287acffece4f78451e160fafa040a988f5a
Author: Douglas Viroel <email address hidden>
Date: Thu Oct 24 17:48:22 2019 -0300

Fix update share network tests and skip exception issue

    After fixing a bug that was allowing share network update when it
    shouldn't, the test that validates the share network creation and
    update started failing. An additional validation was introduced and
    it caused the new bug. This patch fixes the test and make it work
    properly.
    In addition this patch fixes test classes that are raising a skip
    exception inside the setUpClass function and failing due to testtool
    issue #272.

    Closes-Bug: #1849728
    Closes-Bug: #1849377
    Related-Bug: #1846836
    Co-Author: Carlos Eduardo <email address hidden>
    Change-Id: I5b27ee4a9e844ea48dc9324bcf38f5767223717f

Changed in python-manilaclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-10-30: Fix proposed to python-manilaclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/692186

Goutham Pacha Ravi (gouthamr) on 2019-10-30

Changed in python-manilaclient:
importance:	Undecided → Critical
milestone:	none → ussuri-1
tags:	added: ci
tags:	added: breakfix

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-10-30: Fix merged to python-manilaclient (stable/train)

Reviewed: https://review.opendev.org/692186
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=454ab514568d0943a685e7dd31e14dfed1e04925
Submitter: Zuul
Branch: stable/train

commit 454ab514568d0943a685e7dd31e14dfed1e04925
Author: Douglas Viroel <email address hidden>
Date: Thu Oct 24 17:48:22 2019 -0300

Fix update share network tests and skip exception issue

    Closes-Bug: #1849728
    Closes-Bug: #1849377
    Related-Bug: #1846836
    Co-Author: Carlos Eduardo <email address hidden>
    Change-Id: I5b27ee4a9e844ea48dc9324bcf38f5767223717f
    (cherry picked from commit 0ca91287acffece4f78451e160fafa040a988f5a)