share network create on OSC fails with AZ

Bug #1962288 reported by Eduardo Santos
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
Low
Hassan Asghar

Bug Description

Using the --availability-zone option in the openstack share network create command fails with 'get() takes 1 positional argument but 2 were given'. The equivalent command (manila share-network-create) succeeds using the same options.

Debug run from OSC: https://paste.opendev.org/show/812932/
Debug run from manilaclient: https://paste.opendev.org/show/bFl9R4NB7zZzyukikyMW/

Changed in python-manilaclient:
assignee: nobody → Hassan Asghar (hassanasghar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)
Changed in python-manilaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :
Changed in python-manilaclient:
milestone: none → zed-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-manilaclient (master)

Change abandoned by "Hassan Asghar <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/837124
Reason: It had some formatting issues and contains duplicate ids
Here is link to the original change
https://review.opendev.org/c/openstack/python-manilaclient/+/837116

Changed in python-manilaclient:
milestone: zed-1 → antelope-2
Changed in python-manilaclient:
milestone: antelope-2 → antelope-client-release
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/837116
Committed: https://opendev.org/openstack/python-manilaclient/commit/1e379145023484e50bf60e57bb257dcd1fe53da5
Submitter: "Zuul (22348)"
Branch: master

commit 1e379145023484e50bf60e57bb257dcd1fe53da5
Author: hassanasghar <email address hidden>
Date: Thu Apr 7 19:26:01 2022 +0000

    Fix share network create command with the AZ option

    Previously, "share network create" command was trying to look up
    the availability-zone provided by the user. However, this is not supported
    by the AvailabilityZoneManager.

    Drop the AZ lookup if the option is used and pass the user provided value
    to the API.

    Closes-Bug: 1962288
    Change-Id: I3ec926122eed932caebcb31b9afd0f811f1f3c8e

Changed in python-manilaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/zed)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/877024
Committed: https://opendev.org/openstack/python-manilaclient/commit/2128ea1729a512336cab6e323b210b646dec6489
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 2128ea1729a512336cab6e323b210b646dec6489
Author: hassanasghar <email address hidden>
Date: Thu Apr 7 19:26:01 2022 +0000

    Fix share network create command with the AZ option

    Previously, "share network create" command was trying to look up
    the availability-zone provided by the user. However, this is not supported
    by the AvailabilityZoneManager.

    Drop the AZ lookup if the option is used and pass the user provided value
    to the API.

    Closes-Bug: 1962288
    Change-Id: I3ec926122eed932caebcb31b9afd0f811f1f3c8e
    (cherry picked from commit 1e379145023484e50bf60e57bb257dcd1fe53da5)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/yoga)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/877636
Committed: https://opendev.org/openstack/python-manilaclient/commit/08b11ade05e179818ca228e281397bd369849d57
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 08b11ade05e179818ca228e281397bd369849d57
Author: hassanasghar <email address hidden>
Date: Thu Apr 7 19:26:01 2022 +0000

    Fix share network create command with the AZ option

    Previously, "share network create" command was trying to look up
    the availability-zone provided by the user. However, this is not supported
    by the AvailabilityZoneManager.

    Drop the AZ lookup if the option is used and pass the user provided value
    to the API.

    Closes-Bug: 1962288
    Change-Id: I3ec926122eed932caebcb31b9afd0f811f1f3c8e
    (cherry picked from commit 1e379145023484e50bf60e57bb257dcd1fe53da5)
    (cherry picked from commit 2128ea1729a512336cab6e323b210b646dec6489)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/xena)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/878013

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/878013
Committed: https://opendev.org/openstack/python-manilaclient/commit/8be44b686feed1c901080202c09d7c51d24f8477
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 8be44b686feed1c901080202c09d7c51d24f8477
Author: hassanasghar <email address hidden>
Date: Thu Apr 7 19:26:01 2022 +0000

    Fix share network create command with the AZ option

    Previously, "share network create" command was trying to look up
    the availability-zone provided by the user. However, this is not supported
    by the AvailabilityZoneManager.

    Drop the AZ lookup if the option is used and pass the user provided value
    to the API.

    NOTE:
    Unfortunately, we didn't cherry-pick this into 2023.1 before
    cherry-picks were made to older branches (stable/zed...)

    Closes-Bug: 1962288
    Change-Id: I3ec926122eed932caebcb31b9afd0f811f1f3c8e
    (cherry picked from commit 1e379145023484e50bf60e57bb257dcd1fe53da5)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/878012
Committed: https://opendev.org/openstack/python-manilaclient/commit/92e701cf5fd594fa3483ab6885e087e073038941
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 92e701cf5fd594fa3483ab6885e087e073038941
Author: hassanasghar <email address hidden>
Date: Thu Apr 7 19:26:01 2022 +0000

    Fix share network create command with the AZ option

    Previously, "share network create" command was trying to look up
    the availability-zone provided by the user. However, this is not supported
    by the AvailabilityZoneManager.

    Drop the AZ lookup if the option is used and pass the user provided value
    to the API.

    Closes-Bug: 1962288
    Change-Id: I3ec926122eed932caebcb31b9afd0f811f1f3c8e
    (cherry picked from commit 1e379145023484e50bf60e57bb257dcd1fe53da5)
    (cherry picked from commit 2128ea1729a512336cab6e323b210b646dec6489)
    (cherry picked from commit 08b11ade05e179818ca228e281397bd369849d57)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 3.3.2

This issue was fixed in the openstack/python-manilaclient 3.3.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 4.4.0

This issue was fixed in the openstack/python-manilaclient 4.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 4.1.2

This issue was fixed in the openstack/python-manilaclient 4.1.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 3.0.3

This issue was fixed in the openstack/python-manilaclient 3.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 4.5.0

This issue was fixed in the openstack/python-manilaclient 4.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.