python-manilaclient

v2/shares list _instances uses wrong manager

Bug #1966441 reported by Maurice Escher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
Medium
Maurice Escher
python-manilaclient zed-1

Bug Description

Hi,

I wanted to operate on the results of v2/shares list_instances().
But I could not do so, because it uses the ShareManager instead of ShareInstanceManager.

see https://paste.opendev.org/show/bgWN2t5vbfKv8DqqGnWH/

In the example it calls reset_state() method from shares, but I wanted reset_state() from share_instances.

Best,
Maurice

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/835218

Changed in python-manilaclient:
status: New → In Progress
Maurice Escher (maurice-escher)
Changed in python-manilaclient:
assignee: nobody → Maurice Escher (maurice-escher)
Goutham Pacha Ravi (gouthamr)
Changed in python-manilaclient:
importance: Undecided → Medium
milestone: none → zed-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/835218
Committed: https://opendev.org/openstack/python-manilaclient/commit/eeece589207c7cf11384c3a94f84ec389b385cbe
Submitter: "Zuul (22348)"
Branch: master

commit eeece589207c7cf11384c3a94f84ec389b385cbe
Author: Maurice Escher <email address hidden>
Date: Fri Mar 25 13:46:27 2022 +0100

    fix manager _list() method when called from another manager

    only occurence of this was listing share_instances at shares

    Closes-Bug: #1966441
    Change-Id: If65dd1e256a9ee50dcda98a9a0804d4986efa014

Changed in python-manilaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 4.1.0

This issue was fixed in the openstack/python-manilaclient 4.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/899838

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.