python-manilaclient

functional tests fail on python3.10: ValueError: 'Optional arguments:' is not in list

Bug #2000092 reported by Goutham Pacha Ravi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
High
Goutham Pacha Ravi
python-manilaclient antelope-2

Bug Description

 ==============================
 Failed 2 tests - output below:
 ==============================

 manilaclient.tests.functional.test_common.ManilaClientTestCommonReadOnly.test_help_1_admin
 ------------------------------------------------------------------------------------------

 Captured traceback:
 ~~~~~~~~~~~~~~~~~~~
     Traceback (most recent call last):

       File "/home/zuul/src/opendev.org/openstack/python-manilaclient/.tox/functional/lib/python3.10/site-packages/ddt.py", line 220, in wrapper
     return func(self, *args, **kwargs)

       File "/home/zuul/src/opendev.org/openstack/python-manilaclient/manilaclient/tests/functional/test_common.py", line 38, in test_help
     cmds_end = lines.index('Optional arguments:')

     ValueError: 'Optional arguments:' is not in list

 manilaclient.tests.functional.test_common.ManilaClientTestCommonReadOnly.test_help_2_user
 -----------------------------------------------------------------------------------------

 Captured traceback:
 ~~~~~~~~~~~~~~~~~~~
     Traceback (most recent call last):

       File "/home/zuul/src/opendev.org/openstack/python-manilaclient/.tox/functional/lib/python3.10/site-packages/ddt.py", line 220, in wrapper
     return func(self, *args, **kwargs)

       File "/home/zuul/src/opendev.org/openstack/python-manilaclient/manilaclient/tests/functional/test_common.py", line 38, in test_help
     cmds_end = lines.index('Optional arguments:')

     ValueError: 'Optional arguments:' is not in list

Revision history for this message
Goutham Pacha Ravi (gouthamr) wrote :

https://docs.python.org/3/whatsnew/3.10.html#argparse

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-manilaclient/+/868128

Changed in python-manilaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/868128
Committed: https://opendev.org/openstack/python-manilaclient/commit/cb14e965efbdda1ae55f85b4650d299f2c08d0bf
Submitter: "Zuul (22348)"
Branch: master

commit cb14e965efbdda1ae55f85b4650d299f2c08d0bf
Author: Goutham Pacha Ravi <email address hidden>
Date: Mon Dec 19 12:36:57 2022 -0800

    Fix functional tests failing with python 3.10

    argparse module had a change [1] in header text denoting optional
    arguments. The header text now reads "options" instead of
    "optional arguments"

    [1] https://docs.python.org/3/whatsnew/3.10.html#argparse
    Closes-Bug: #2000092

    Change-Id: I2d7caa6e3c5a6a493639dc655a6722992540281e

Changed in python-manilaclient:
status: In Progress → Fix Released
Goutham Pacha Ravi (gouthamr)
Changed in python-manilaclient:
importance: Undecided → High
assignee: nobody → Goutham Pacha Ravi (gouthamr)
milestone: none → antelope-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-manilaclient 4.3.0

This issue was fixed in the openstack/python-manilaclient 4.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.