Novaclient flavors.create needs cleanup
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-novaclient |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The conversion from integer-only required flavor ids in novaclient to allowing string ids and autogenerated ids needs some cleanup. REferring to the code here:
https:/
1. The docstring still refers to the id as a required integer.
2. The flavor id argument, given it's position, could have been converted into a kwarg with a value of None with no alteration to the method signature. This would have eliminated the need for the "auto" special-cased name.
3. The current implementation means that you can't create a flavor named "auto". While this isn't a huge issue, it is still an unnecessary artificial restriction on the possible set.
affects: | nova → python-novaclient |
Changed in python-novaclient: | |
status: | Fix Committed → Fix Released |
There's also a typo in that code; the variable "ephemeral" is misspelled and thus never properly used.