Expand shell test coverage for security groups

Hi Matt, Nova does not allow adding two security groups of the same name. Thus, the whole logic of checking if two matches with same name exists will never be executed. Am I missing something here?

Hi Abhishek, I think my point is:

1. The novaclient v1.1 shell test doesn't cover this case for duplicate names:

https://github.com/openstack/python-novaclient/blob/master/novaclient/v1_1/shell.py#L2125

2. There is no security group test coverage for v3 in novaclient that I can tell. I think it should be trivial to port the test(s) that were added in the review linked above to the v3 shell in novaclient. I opened the bug rather than require the author of that review to write those tests since his change didn't impact the v3 shell.

Fix proposed to branch: master
Review: https://review.openstack.org/62011

patch was abandoned due to a blocker, looks like that is resolved and the patch can be brought back. but the patch isn't actively in progress anymore.

This seems to be done. Do we think there is more work required here? I will update my review to remove the v3 api stuff, will also update the commit message.

Reviewed: https://review.openstack.org/62011
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=a20284ebe8973beb5f80bb54458c2c817e184c42
Submitter: Jenkins
Branch: master

commit a20284ebe8973beb5f80bb54458c2c817e184c42
Author: Abhishek Chanda <email address hidden>
Date: Fri Dec 13 20:34:25 2013 +0530

    Add some security group tests for the V1_1 API

    This patch adds a test for NoUniqueMatch exception
    to the v1_1 API

    Change-Id: Ic9947eaed34be100c529f021432f0c388a7c3ddb
    Closes-Bug: #1250501