instance_id always set on datedirs when using configglue
Bug #1019699 reported by
James Westby
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-oops-dictconfig |
In Progress
|
Critical
|
James Westby |
Bug Description
Defining instance_id in the schema means that it has a default value of '', so when
it's not set in the config file you get overwritten oopses.
That's bad.
Maybe the default should be set to None in the configglue schema, or maybe there's
another fix.
Related branches
lp://qastaging/~james-w/python-oops-dictconfig/instance-id-default
Ready for review
for merging
into
lp://qastaging/python-oops-dictconfig
- James Westby (community): Approve
- Diogo Baeder (community): Approve
-
Diff: 86 lines (+22/-4)5 files modifiedREADME (+0/-3)
oops_dictconfig/configglue_options.py (+1/-0)
oops_dictconfig/tests/__init__.py (+1/-0)
oops_dictconfig/tests/test_configglue_options.py (+19/-0)
tarmac_tests.sh (+1/-1)
Changed in python-oops-dictconfig: | |
status: | Triaged → In Progress |
To post a comment you must log in.