network show command always shows router_external = Internal

Bug #1572228 reported by Brad Behle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Low
Richard Theis

Bug Description

Even for external networks, the openstack network show command shows router_external = Internal. The best way to do this is to compare "neutron net-show public" output with "openstack network show public" output on a devstack environment that is using neutron.

I think this has to do with the property being "router:external", but at some point in the code the key is translated to router_external, so when the code looks up the value for router_external, it doesn't find anything, causing it to assume it is "Internal". I think this might also affect network set --internal (since the code thinks it already is internal.

Richard Theis (rtheis)
Changed in python-openstackclient:
assignee: nobody → Richard Theis (rtheis)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstackclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/308019

Changed in python-openstackclient:
status: New → In Progress
Richard Theis (rtheis)
Changed in python-openstackclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/308019
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=9f3fa5ee3bf87c47f7a38ef78f4022ac46b2f2f6
Submitter: Jenkins
Branch: master

commit 9f3fa5ee3bf87c47f7a38ef78f4022ac46b2f2f6
Author: Richard Theis <email address hidden>
Date: Tue Apr 19 14:42:01 2016 -0500

    Fix network router type display

    The OpenStack SDK maps the network "router:external" field to
    "is_router_external". However, OSC was using the incorrect
    mapping, "router_external". This caused OSC to display router
    type as "Internal" for all networks.

    Change-Id: Ifcd1349ab7c5881baee751936d076bf6aa058852
    Closes-Bug: #1572228

Changed in python-openstackclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-openstackclient 2.5.0

This issue was fixed in the openstack/python-openstackclient 2.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.