Client health will never be true

Bug #1288986 reported by Jay Baugh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Python client library for Zaqar
Fix Released
Undecided
Doraly Navarro

Bug Description

The API returns a 204 for the health check with no body content.

The core.health function returns the content, which is always empty.

This should function should return a True if http result was a 204, or else a False.

Changed in python-marconiclient:
status: New → Confirmed
Changed in python-zaqarclient:
assignee: nobody → Doraly Navarro (doralynavarro)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-zaqarclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134149

Changed in python-zaqarclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-zaqarclient (master)

Reviewed: https://review.openstack.org/134149
Committed: https://git.openstack.org/cgit/openstack/python-zaqarclient/commit/?id=2cb7e9054f7af59b4091b84f009d6d8de1eb2ed4
Submitter: Jenkins
Branch: master

commit 2cb7e9054f7af59b4091b84f009d6d8de1eb2ed4
Author: dynarro <email address hidden>
Date: Thu Nov 13 10:14:26 2014 +0100

    Makes health return True or False

    API returns a 204 for the health check with no body content.
    The function should have returned True if http result was a 204,
    or else a False.

    I solved the problem by making the function return false in case of an
    error.

    Change-Id: I02771f5aa61db4ed83da952245744cb3a6163a26
    Closes-bug: #1288986

Changed in python-zaqarclient:
status: In Progress → Fix Committed
Changed in python-zaqarclient:
milestone: none → 0.2.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.