A load balancer/proxy such as HAProxy may return 504 and an HTML body. In that case, the client raises a ValueError in transport/response.py when it attempts to decode the body.
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/gevent/greenlet.py", line 327, in run
result = self._run(*self.args, **self.kwargs)
File "/root/zaqar/zaqar/bench/producer.py", line 86, in producer
queue.post(choose_message(message_pool))
File "/usr/local/lib/python2.7/dist-packages/marconiclient/queues/v1/queues.py", line 104, in post
self._name, messages)
File "/usr/local/lib/python2.7/dist-packages/marconiclient/queues/v1/core.py", line 193, in message_post
return resp.deserialized_content
File "/usr/local/lib/python2.7/dist-packages/marconiclient/transport/response.py", line 47, in deserialized_content
self._deserialized = json.loads(self.content)
File "/usr/lib/python2.7/json/__init__.py", line 326, in loads
return _default_decoder.decode(s)
File "/usr/lib/python2.7/json/decoder.py", line 365, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.7/json/decoder.py", line 383, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
Can the LB be configured to return something else instead of the HTML? Why should zaqarclient care about this?
I may be wrong here but I think it's completely fair to just assume the response is of the expected type. We could add a check on the content-type but then we also need to answer the question of what the client should do if the content-type is not supported. Should it raise an exception? Should the 504 be communicated back to the user?