Rally

Add hacking rules to not use list() and dict() and use [] and {}

Bug #1437515 reported by Boris Pavlovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rally
Fix Released
Wishlist
Hugh Ma
Rally 0.0.4

Bug Description

We shouldn't use dict() and list() it's bad practice much better

So i prefer to add hacking rule here:

https://github.com/stackforge/rally/tree/master/tests/hacking

And fix all occurrences.

Boris Pavlovic (boris-42)
Changed in rally:
importance: Undecided → Wishlist
status: New → In Progress
status: In Progress → Triaged
Hugh Ma (hughkma)
Changed in rally:
assignee: nobody → Hugh Ma (hughkma)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to rally (master)

Fix proposed to branch: master
Review: https://review.openstack.org/173410

Changed in rally:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/173410
Committed: https://git.openstack.org/cgit/stackforge/rally/commit/?id=98cde5e8c577f6cca2f4c7cbf80c075204f34780
Submitter: Jenkins
Branch: master

commit 98cde5e8c577f6cca2f4c7cbf80c075204f34780
Author: Hugh Ma <email address hidden>
Date: Tue Apr 14 09:12:11 2015 -0700

    Data structs declared with constructor replaced with literal

    Changes:
      - list() declarations replaced with []
      - dict() declarations replaced with {}
      - Added N351 to hacking for literal rule along with checks, test hacking, and to readme
      - Minor fix to incorrect path in hacking guidelines pointing to test_hacking.py

    Change-Id: Ie7b9201d61b6f2024217b6f4117605eb52fa916a
    Closes-Bug: #1437515

Changed in rally:
status: In Progress → Fix Committed
Boris Pavlovic (boris-42)
Changed in rally:
status: Fix Committed → Fix Released
Boris Pavlovic (boris-42)
Changed in rally:
status: Fix Released → Fix Committed
Andriy Kurilin (andreykurilin)
Changed in rally:
milestone: none → 0.0.4
Boris Pavlovic (boris-42)
Changed in rally:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.