Reproduce steps:
1. Click "create cluster template" in GUI, fill in the template name
2. In "Node Groups" panel, select one "Node Group" template from the drop down menu.
3. Click "Create" to submit
4. The GUI will complain: Error: Internal Server Error
Below is the related savanna log:
,-----------
| 2013-11-09 00:51:11.921 30264 DEBUG keystoneclient.middleware.auth_token [-] Returning cached token cb0579d212138817b38e21b3f1da22f0 _cache_get /opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/keystoneclient/middleware/auth_token.py:1016
| 2013-11-09 00:51:11.921 30264 DEBUG keystoneclient.middleware.auth_token [-] Received request from user: 920bc9b59c364187acbe4ab9d9303435 with project_id : 3ff53985b7874ec9b6c08d8063245694 and roles: admin _build_user_headers /opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/keystoneclient/middleware/auth_token.py:922
| 2013-11-09 00:51:11.922 30264 DEBUG savanna.utils.api [-] Rest.route.decorator.handler, kwargs={'tenant_id': u'3ff53985b7874ec9b6c08d8063245694'} handler /opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/utils/api.py:63
| 2013-11-09 00:51:11.935 30264 ERROR savanna.utils.api [-] Request aborted with status code 500 and message 'Internal Server Error'
| 2013-11-09 00:51:11.936 30264 ERROR savanna.utils.api [-] Traceback (most recent call last):
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/utils/api.py", line 86, in handler
| return func(**kwargs)
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/service/validation.py", line 50, in handler
| return func(*args, **kwargs)
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/api/v10.py", line 78, in cluster_templates_create
| return u.render(api.create_cluster_template(data).to_wrapped_dict())
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/service/api.py", line 214, in create_cluster_template
| return conductor.cluster_template_create(context.ctx(), values)
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/conductor/resource.py", line 40, in handle
| ret = func(*args, **kwargs)
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/conductor/api.py", line 164, in cluster_template_create
| return self._manager.cluster_template_create(context, values)
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/conductor/manager.py", line 235, in cluster_template_create
| return self.db.cluster_template_create(context, values)
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/db/api.py", line 94, in decorator
| res = func(*args, **kwargs)
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/db/api.py", line 203, in cluster_template_create
| return IMPL.cluster_template_create(context, values)
| File "/opt/stack/savanna/savanna-venv/local/lib/python2.7/site-packages/savanna/db/sqlalchemy/api.py", line 356, in cluster_template_create
| for ng in node_groups:
| TypeError: 'NoneType' object is not iterable
|
| 2013-11-09 00:51:12.165 30264 DEBUG keystoneclient.middleware.auth_token [-] Authenticating user token __call__ /opt/stack/savanna/savanna-v
`-----------
This is acutally about: when users creating cluster template, they must not only select "node group template", and decide how many nodes what to launch.
Two suggestions for this bug:
1. GUI enforce this check, instad of a blind go.
2. api.py be more code fensive, instead of throw a misleading exception of "'NoneType' object is not iterable"