don't display inappropriate quickstart results
Bug #1604453 reported by
Kyle Nitzsche
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Photos Scope |
Fix Released
|
High
|
Penk Chen | ||
Today Scope |
Fix Released
|
High
|
Penk Chen | ||
scope-aggregator |
Fix Released
|
High
|
Kyle Nitzsche |
Bug Description
scope-aggregator should not display quickstart help for child scopes that are not installed or for Settings> Accounts for inappropriate locales.
For example, the photos scope displays help that includes a login result for facebook (photos), even if the facebook photos child scope is not installed.
Another example, Today scope should not display a button to open Settings > Accounts > Google in China.
Related branches
lp://qastaging/~knitzsche/scope-aggregator/bug-1602141-only-show-help-for-installed
- Gary.Wang: Needs Fixing
- Zhang Enwei (community): Approve
- Penk Chen: Pending requested
-
Diff: 86 lines (+36/-4)3 files modifiedCMakeLists.txt (+1/-1)
data/hints.json (+1/-0)
src/utils.cpp (+34/-3)
Changed in photos-scope: | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Kyle Nitzsche (knitzsche) |
To post a comment you must log in.
Here is a screenshot of the facebook quick start result (in China) that should not be displayed.