shaker

shaker-image-builder fails, missing positional argument to heat API

Bug #1848368 reported by Sean M. Collins on 2019-10-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	shaker	Fix Released	Undecided	Unassigned

Bug Description

2019-10-16 14:09:20.384 46757 INFO shaker.engine.utils [-] Logging enabled
2019-10-16 14:09:21.263 46757 INFO shaker.openstack.clients.openstack [-] Connection to OpenStack is initialized
2019-10-16 14:09:23.462 46757 INFO shaker.engine.image_builder [-] Created flavor shaker-flavor
2019-10-16 14:09:28.925 46757 INFO shaker.engine.image_builder [-] Detected build mode is "heat"
2019-10-16 14:09:28.925 46757 INFO shaker.engine.utils [-] Alias "ubuntu" is resolved into file ".venv/lib/python3.7/site-packages/shaker/resources/image_builder_templates/ubuntu.yaml"
2019-10-16 14:09:29.110 46757 ERROR shaker.engine.image_builder [-] Error while building the image: create_stack() missing 1 required positional argument: 'environment'
2019-10-16 14:09:29.110 46757 ERROR shaker.engine.image_builder [-] create_stack() missing 1 required positional argument: 'environment': TypeError: create_stack() missing 1 required positional argument: 'environment'
2019-10-16 14:09:29.110 46757 ERROR shaker.engine.image_builder Traceback (most recent call last):
2019-10-16 14:09:29.110 46757 ERROR shaker.engine.image_builder File ".venv/lib/python3.7/site-packages/shaker/engine/image_builder.py", line 87, in build_image_with_heat
2019-10-16 14:09:29.110 46757 ERROR shaker.engine.image_builder template, stack_parameters)
2019-10-16 14:09:29.110 46757 ERROR shaker.engine.image_builder TypeError: create_stack() missing 1 required positional argument: 'environment'
2019-10-16 14:09:29.110 46757 ERROR shaker.engine.image_builder

Revision history for this message

Sean M. Collins (scollins) wrote on 2019-10-16:

https://opendev.org/performa/shaker/commit/dc5d0ce4ce2b0bdb109b70853456076556201861 appears to have added this positional parameter, but does not set a default if none is provided. Which means this breaks everyone who doesn't have an environment file set