publish complains about desktop file un-necessarily

Bug #1670162 reported by Alan Pope 🍺🐧🐱 🦄
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Click Reviewers tools (obsolete)
Fix Released
Low
Jamie Strandboge
Snapcraft
Triaged
Low
Unassigned
Software Center Agent
Invalid
Undecided
Unassigned

Bug Description

Publishing a snap which uses the x11 plug but is a command line utility, so doesn't have a .desktop file, I get the following:-

Will need manual review...|
Publishing checks failed.
To release this to stable channel please request a review on the snapcraft list.
Use devmode in the edge or beta channels to disable confinement.
  - desktop interfaces (x11) specified without meta/gui/*.desktop. Please provide a desktop file via setup/gui/*.desktop if using snapcraft or meta/gui/*.desktop otherwise. It should reference one of the 'apps' from your snapcraft/snap.yaml.

Surely x11 related things can exist without desktop files?

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

This is not a snapcraft error but a store/click-review thing.

Also, just to be pedantic, snapcraft does not publish ;-)

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Oh and the publish comment was not directed at you bug reporter! :-)

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

This needs to be fixed in snapcraft: snapcraft/storeapi/errors.py: 'Publishing checks failed.\n'

Changed in snapcraft:
status: New → Triaged
importance: Undecided → Low
Changed in software-center-agent:
status: New → Invalid
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I'll figure out a way to make this per-snap overrideable. The test is important due to bug #1643910.

Changed in click-reviewers-tools:
assignee: nobody → Jamie Strandboge (jdstrand)
importance: Undecided → Low
status: New → In Progress
Changed in click-reviewers-tools:
status: In Progress → Fix Committed
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This is now fixed in the review tools in the store so marking that task Fix Released.

Changed in click-reviewers-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.