ClassAlias Reference is compiled to wrong sql

It seems a little bit more subtle than that. The translation of the example given in a test case worked for me: http://pastebin.ubuntu.com/538211/

It's a problem with Reference compilation. I'm looking at it.

Here is a simple test case:

    def test_alias_reference(self):
        c = StringIO()
        debug(True, c)
        Bar1 = ClassAlias(Bar, "bar1")
        self.store.find(Bar1, Bar1.foo == None).one()
        data = c.getvalue()
        self.assertNotIn("bar.foo_id IS NULL", data)

Unfortunately it's more complicated than I thought. I don't know how to fix that for now.

I may try to have a look at it.. can you please outline what you found and why it feels tricky?

Sure. The problem I think is that the Reference doesn't know if it's called on the original class or the alias. _local_key is not updated, and thus the relation built has no idea that the class is not the original class. There may be something wrong with _find_descriptor_class too, because it can't return the alias class as it browses the MRO. I *think* if Relation._build_relation is fixed so that self._local_key.table ends up pointing at the alias class, it should work.

Jeroen,

You have probably already found this work around, but I will go ahead and document it here in the bug.
With this table structure:
        class Other(object):
            __storm_table__ = "other_table"
            prop1 = Property("column1", primary=True)
        class Class(object):
            __storm_table__ = "table"
            prop1 = Property("column1", primary=True)
            other_ref_id = Property("column1_ref_id")
            other_ref = Reference(other_ref_id, Other.prop1)
        ClassAlias = ClassAlias(self.Class, "alias")

store.find(ClassAlias.prop1, ClassAlias.other_ref == 1)
will generate WHERE "table".column1_ref_id = 1;
But, store.find(ClassAlias.prop1, ClassAlias.other_ref_id == 1)
will generate WHERE alias.column1_ref_id = 1;