Mismatch dictionary key in the process of parsing XML

Bug #1214198 reported by Hua Zhang
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fix Released
Hua Zhang

Bug Description

Should be 'addr': child.get('version') -> 'addr': child.get('addr') in the _parse_network method of servers_client.py

$ git diff
diff --git a/tempest/services/compute/xml/servers_client.py b/tempest/services/compute/xml/servers_client.py
index 12e7034..5c7a629 100644
--- a/tempest/services/compute/xml/servers_client.py
+++ b/tempest/services/compute/xml/servers_client.py
@@ -350,7 +350,7 @@ class ServersClientXML(RestClientXML):
         addrs = []
         for child in node.getchildren():
             addrs.append({'version': int(child.get('version')),
- 'addr': child.get('version')})
+ 'addr': child.get('addr')})
         return {node.get('id'): addrs}

     def list_addresses(self, server_id):

Hua Zhang (zhhuabj)
Changed in tempest:
assignee: nobody → Hua Zhang (zhhuabj)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/42797

Changed in tempest:
status: New → In Progress
Changed in tempest:
milestone: none → havana-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tempest (master)

Reviewed: https://review.openstack.org/42797
Committed: http://github.com/openstack/tempest/commit/cc51ccd09d148d29195fcec39177ff7e64cb747a
Submitter: Jenkins
Branch: master

commit cc51ccd09d148d29195fcec39177ff7e64cb747a
Author: zhhuabj <email address hidden>
Date: Tue Aug 20 09:50:47 2013 +0800

    Mismatch dictionary key in the process of parsing XML

    Should be:
    'addr': child.get('version') -> 'addr': child.get('addr'),
    in the _parse_network method of servers_client.py

    Change-Id: Ida6cf5ce5b2b5b89b5fadb7705798fe44a913a33
    Closes-Bug: #1214198

Changed in tempest:
status: In Progress → Fix Committed
Changed in tempest:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.