Authentication and authorization configuration is a complete mess

Bug #966482 reported by Jay Pipes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tempest
Fix Released
Critical
Jay Pipes

Bug Description

======================================================================
ERROR: test suite for <class 'tempest.tests.test_volumes_negative.VolumesTest'>
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/nose/suite.py", line 208, in run
    self.setUp()
  File "/usr/lib/pymodules/python2.7/nose/suite.py", line 291, in setUp
    self.setupContext(ancestor)
  File "/usr/lib/pymodules/python2.7/nose/suite.py", line 314, in setupContext
    try_run(context, names)
  File "/usr/lib/pymodules/python2.7/nose/util.py", line 478, in try_run
    return func()
  File "/home/jpipes/repos/tempest/tempest/tests/test_volumes_negative.py", line 12, in setUpClass
    cls.os = openstack.Manager()
  File "/home/jpipes/repos/tempest/tempest/openstack.py", line 26, in __init__
    if None in [username, password, tenant_name]:
UnboundLocalError: local variable 'password' referenced before assignment

Getting these all over the place...

We really need a real gating job.

The sample config file (https://github.com/openstack/tempest/blob/master/etc/tempest.conf.sample)

is still showing nonadmin1_user in the identity section. we need to pull this back out and get ahold of the way identity stuff is tested and configured...

Revision history for this message
Jay Pipes (jaypipes) wrote :

So, it looks like this is fixed in trunk, but when I rebase various branches against master, changes are not being applied correctly. Reall not sure why, but we're going to have to push fixes for this stuff to all the outstanding merge requests. :( Ugh.

Changed in tempest:
status: In Progress → Invalid
Revision history for this message
Jay Pipes (jaypipes) wrote :

I believe this happened because the patch that added the nonadmin1_user stuff was reverted, but not the corresponding change to the oepnstack.Manager class. :(

Jay Pipes (jaypipes)
summary: - UnboundLocalError: local variable 'password' referenced before
- assignment
+ Authentication and authorization configuration is a complete mess
Changed in tempest:
status: Invalid → In Progress
description: updated
Revision history for this message
David Kranz (david-kranz) wrote : Re: [Bug 966482] Re: UnboundLocalError: local variable 'password' referenced before assignment

On 3/27/2012 3:18 PM, Jay Pipes wrote:
> I believe this happened because the patch that added the nonadmin1_user
> stuff was reverted, but not the corresponding change to the
> oepnstack.Manager class. :(
>
I don't know why you say the nonadmin1_user stuff was reverted. I see it
on github/master
and had to change the stress destroy all in my submission currently posted.

Revision history for this message
David Kranz (david-kranz) wrote :

I don't think it was reverted. It is on github in master.

Revision history for this message
Daryl Walleck (dwalleck) wrote :

I'm confused here. Let me get ahold of what's going on here before I go any further. I made the change to the manager class and config in one commit.

Revision history for this message
Daryl Walleck (dwalleck) wrote :

I'm running Tempest off trunk against Devstack from trunk and not having any issues. Are you sure you didn't mix in changes from several branches? I'm doing full Tempest runs on Devstack before each submission. I'd be more than glad to even put up a public Jenkins instance to reflect that.

Revision history for this message
Daryl Walleck (dwalleck) wrote :

>>On 3/27/2012 3:18 PM, Jay Pipes wrote:
>> I believe this happened because the patch that added the nonadmin1_user
>> stuff was reverted, but not the corresponding change to the
>> oepnstack.Manager class. :(
>>
>I don't know why you say the nonadmin1_user stuff was reverted. I see it
>on github/master
>and had to change the stress destroy all in my submission currently posted.

dprince was concerned by the changes to the config file and asked if the config file could be more stable. Based on that feedback, I was asked to revert my change and go about it another way.

Revision history for this message
David Kranz (david-kranz) wrote :

I understand. I am just saying it has not been reverted. I don't have troubles either. The fix came from https://github.com/openstack/tempest/commit/c341a90d16ed5d54af10d33ba60b490859210ba3 after your change I think.

Jay Pipes (jaypipes)
Changed in tempest:
status: In Progress → Fix Committed
Jay Pipes (jaypipes)
Changed in tempest:
status: Fix Committed → Fix Released
Sean Dague (sdague)
Changed in tempest:
milestone: none → havana-3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.