tripleo

NIC config templates using 'role_tags' does not work with baremetal provisioning network config workflow

Bug #2039008 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Triaged
High
Harald Jensås

Bug Description

Some of the network config templates shipped with tripleo-ansible uses the `role_tags` in jinja2. For example: roles/tripleo_network_config/templates/multiple_nics/multiple_nics.j2

    {% elif network in role_networks or 'external_bridge' in role_tags %}

Using this template fails because 'role_tags' is not defined.

The schema does not allow setting the variable:
  https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/module_utils/baremetal_deploy.py#L50-L72

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/897923

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/897923
Committed: https://opendev.org/openstack/tripleo-ansible/commit/718dc67661e9cad656f2f79f84703d41415fb1cc
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 718dc67661e9cad656f2f79f84703d41415fb1cc
Author: Harald Jensås <email address hidden>
Date: Wed Oct 11 09:22:21 2023 +0200

    Add 'role_tags' to network_config schema

    Some of the network config templates shipped with tripleo-ansible
    uses the `role_tags` in jinja2. For example:
      roles/tripleo_network_config/templates/multiple_nics/multiple_nics.j2

     elif network in role_networks or 'external_bridge' in role_tags

    This change add's 'role_tags' to the network_config schema for
    baremeteal deployment definition.

    Closes-Bug: #2039008
    Change-Id: I15e7e03c40d9334a665f7063df90bcddcccabfd4

tags: added: in-stable-wallaby
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.