Wrong PID name for PostgreSQL in Ubuntu image

https://review.openstack.org/#/c/535369/

Change abandoned by Ga?tan Trellu (<email address hidden>) on branch: master
Review: https://review.openstack.org/535369
Reason: Already fixed there: https://review.openstack.org/#/c/534667/

This bug is resolve by this commit: https://review.openstack.org/#/c/534667/

You can close this bug.

I'm seeing exactly this issue on a devstack setup (master from last week) that makes a xenial guest. I note that the systemd unit file: /lib/systemd/system/postgresql@.service has:

PIDFile=/run/postgresql/%i.pid # note %i = 9.6/main

So 'service postgresql start' and all variants thereof end up hanging forever awaiting the wrong pidfile, and the guest ends up in a state where the service thinks postgres is down but it is actually up.

I think this is happening because the service discovery code in Trove checks for upstart, sysv and systemd in that order. So on xenial it finds a postgresql file in /etc/init.d and decides we are sysv - so does not apply trove/integration/scripts/files/elements/ubuntu-xenial-postgresql/install.d/31-fix-init-script to amend the pifile in the systemd unit. I'm thinking that the detection should be in upstart, systemd then sysv order.

FWIW - manipualating the devstack generated image to fix the systemd unit file, then re-uploading it, results in a guest in ACTIVE state after launching a new instance. So we need to figure out how to apply those existing fixes during the guest image build.

FWIW, there is a ubuntu-xenial-postgresql/install.d/31-fix-init-script that changes the pidfile...however it is either not being run or overwritten later, as the built image (as indicated above) has the wrong pidfile.