ContacstDbusService has no tests
Bug #1332093 reported by
Leo Arias
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Autopilot Tests |
In Progress
|
Critical
|
Brendan Donegan | ||
Bug Description
The helper merged here:
https:/
It's missing the re import.
More importantly, and the reason why we didn't notice that missing import is that the code is not tested. It must have full coverage before going into the UX branch.
Related branches
lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_minor_fixes
- Leo Arias (community): Approve
- Chris Gagnon (community): Approve
-
Diff: 27 lines (+3/-1)1 file modifiedubuntu_experience_tests/helpers.py (+3/-1)
lp://qastaging/~brendan-donegan/ubuntu-autopilot-tests/contacts_dbus_test
- Leo Arias (community): Needs Fixing
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 205 lines (+129/-16)4 files modifieddebian/control (+3/-0)
debian/rules (+1/-0)
tests/test_helpers.py (+113/-0)
ubuntu_experience_tests/helpers.py (+12/-16)
| Changed in ubuntu-autopilot-tests: | |
| status: | Triaged → In Progress |
| Changed in ubuntu-autopilot-tests: | |
| importance: | Undecided → Critical |
Revision history for this message
| Brendan Donegan (brendan-donegan) wrote | #1 |
Revision history for this message
| Leo Arias (elopio) wrote | #2 |
Revision history for this message
| Leo Arias (elopio) wrote Re: ContacstDbusService doesn't has no tests | #3 |
| summary: |
- ContacstDbusService doesn't work and has no tests + ContacstDbusService doesn't has no tests |
| summary: |
- ContacstDbusService doesn't has no tests + ContacstDbusService has no tests |
To post a comment you must log in.
Imo this is simple enough that the incidental testing by way of being used in other tests should be enough. I'm not opposed to writing a few tests though - it should be simple enough.