sysstat service enablement state mismatches debconf and /etc/default/sysstat setting
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Release Notes for Ubuntu |
New
|
Undecided
|
Unassigned | ||
sysstat (Debian) |
New
|
Unknown
|
|||
sysstat (Ubuntu) |
Fix Released
|
Undecided
|
Robie Basak | ||
Noble |
Triaged
|
Undecided
|
Robie Basak |
Bug Description
[Impact]
When the sysstat package is pre-installed, for example on a fresh Ubuntu 24.04 installation in any cloud image, systemd presets activate the various sysstat systemd services, even when /etc/default/
This causes a divergence between users upgrading to 24.04 from a previous release and fresh installations of 24.04. On upgrade, systemd presets do not get "re"-preset, so sysstat services are disabled. On a fresh installation, systemd presets get "re"-preset on first boot, causing the sysstat services to be enabled despite the default ENABLED="false" package setting.
This results in inconsistent behaviour for users.
Thanks to hideou aoi and Athos Ribeiro for finding and identifying this issue.
[Fix]
Instead of having packaging change the service state of the various sysstat systemd services, we use the systemd ExecCondition directive to run the services only after dynamically consulting /etc/default/
[Test Plan]
Covered by new dep8 test d/t/enablement
[Where problems could occur]
See the corresponding section in bug 2073285 for details, since risks are best considered with the two changes we’re making together.
Related branches
- git-ubuntu bot: Approve
- Andreas Hasenack: Approve
- Canonical Server Reporter: Pending requested
-
Diff: 263 lines (+176/-7)8 files modifieddebian/changelog (+12/-0)
debian/control (+2/-1)
debian/patches/series (+1/-0)
debian/patches/service-conditional-on-setting (+35/-0)
debian/sysstat.postinst (+14/-5)
debian/sysstat.templates (+1/-1)
debian/tests/control (+4/-0)
debian/tests/enablement (+107/-0)
Changed in sysstat (Ubuntu): | |
status: | New → Incomplete |
assignee: | nobody → Robie Basak (racb) |
description: | updated |
Changed in sysstat (Debian): | |
status: | Unknown → New |
Changed in sysstat (Ubuntu): | |
status: | Incomplete → In Progress |
tags: | added: server-todo |
Changed in sysstat (Ubuntu Noble): | |
assignee: | nobody → Robie Basak (racb) |
status: | New → Triaged |
description: | updated |
Testing the Oracular upload:
dep8 tests are added, which check the default, that preset-all no longer sysstat
disrupts things, and that service conditions match /etc/default/
For upgrade testing within Oracular:
Launch Oracular, ENABLED=false, but sysstat- collect. timer is enabled. collect. timer remains enabled.
Upgrade to PPA, ENABLED=true, sysstat-
Launch Oracular, ENABLED=false, but sysstat- collect. timer is enabled. collect. timer becomes disabled. collect. timer becomes enabled.
apt install --reinstall sysstat, sysstat-
Upgrade to PPA, ENABLED=true, sysstat-